[Bug cli/15548] New: Limit completions to a pre-defined limit when completions list is very large

[Bug cli/15548] New: Limit completions to a pre-defined limit when completions list is very large

[pmuldoon at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

            Bug ID: 15548
           Summary: Limit completions to a pre-defined limit when
                    completions list is very large
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: cli
          Assignee: unassigned at sourceware dot org
          Reporter: pmuldoon at redhat dot com

Related: http://sourceware.org/bugzilla/show_bug.cgi?id=9007

When you complete on a symbol with a wide-scope expression (ie bt _<tab>), GDB
can sometimes take a very long time to compile a list of symbols for
completion.  This large symbol list is useless anyway, nobody is going to comb
through 70,000 symbols to find the right one.

In these cases, we should limit the number of symbols iterated to a set limit
before we bail out, and declare the symbol expression too broad for completion.
 This will signal to the user to enter a more tightly defined expression (which
they would do, anyway), and not frustrate them with a long wait while GDB
grinds through thousands of symbols to provide a completion list that is
unusable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[dmalcolm at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

Dave Malcolm <dmalcolm at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[dje at google dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

dje at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje at google dot com,
                   |                            |saugustine at google dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[dje at google dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #1 from dje at google dot com ---
IIRC, This has been proposed before, and was rejected. [fyi]

It would be nice to get this implemented.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[dje at google dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #2 from dje at google dot com ---
One problem I see with implementing this (and hopefully I'm either wrong or
will be easy to fix) is that readline doesn't work the way we want it to for
this purpose.  readline first finds all completions and *then* asks if the user
wants to see them all.  Instead, we need readline to, say, first fetch the
first N+1 items, and then if it returns N+1 then ask the user if s/he wants to
see them all (or the next N, or whatever).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[dje at google dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #3 from dje at google dot com ---
My bad, seems like this can be handled entirely within gdb.
[no readline changes needed: it's gdb's completers that construct the list of
all completions, hopefully there's no reason why we can't just have them query
the user whether s/he wants to continue.
doesn't make much sense for e.g., signal_completer, other than wanting the max
#completions to apply to all completers - seems excessive]

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[manu at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15548

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #4 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Any hints how this could be fixed? I may be willing to give it a try. It is
such a pain the ass.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From gdb-prs-return-13893-listarch-gdb-prs=sources.redhat.com@sourceware.org Tue Jun 25 10:37:59 2013
Return-Path: <gdb-prs-return-13893-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-prs@sources.redhat.com
Received: (qmail 26415 invoked by alias); 25 Jun 2013 10:37:59 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Delivered-To: mailing list gdb-prs@sourceware.org
Received: (qmail 26386 invoked by uid 48); 25 Jun 2013 10:37:59 -0000
From: "tromey at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug remote/15297] CTRL-C with set debug remote often crashes GDB
Date: Tue, 25 Jun 2013 10:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: remote
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tromey at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-15297-4717-aSbmK8gcZm@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-15297-4717@http.sourceware.org/bugzilla/>
References: <bug-15297-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-q2/txt/msg00482.txt.bz2
Content-length: 279

http://sourceware.org/bugzilla/show_bug.cgi?id\x15297

--- Comment #3 from Tom Tromey <tromey at redhat dot com> ---
> Check also currently FAILing: gdb.base/random-signal.exp

How can I make it fail?

--
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Gary Benson <gbenson at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gbenson at redhat dot com

--- Comment #5 from Gary Benson <gbenson at redhat dot com> ---
(In reply to dje from comment #1)
> IIRC, This has been proposed before, and was rejected. [fyi]
> 
> It would be nice to get this implemented.

Doug, do you remember roughly when this was?  I found this thread:
https://sourceware.org/ml/gdb-patches/2008-05/threads.html#00385
https://sourceware.org/ml/gdb-patches/2008-06/threads.html#00042
but as far as I can see that was approved and committed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #6 from dje at google dot com ---
(In reply to Gary Benson from comment #5)
> (In reply to dje from comment #1)
> > IIRC, This has been proposed before, and was rejected. [fyi]
> > 
> > It would be nice to get this implemented.
> 
> Doug, do you remember roughly when this was?  I found this thread:
> https://sourceware.org/ml/gdb-patches/2008-05/threads.html#00385
> https://sourceware.org/ml/gdb-patches/2008-06/threads.html#00042
> but as far as I can see that was approved and committed.

I can't remember.  I'd just go ahead.
If you do, let me know because I've been working on it in bits and pieces but
am happy for someone else to work on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #7 from Gary Benson <gbenson at redhat dot com> ---
I plan to start Monday.  Have you made much progress?  (Is there a branch
somewhere we can maybe collaborate on?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #8 from Gary Benson <gbenson at redhat dot com> ---
See also bug 11920.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Gary Benson <gbenson at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |gbenson at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Gary Benson <gbenson at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #9 from Gary Benson <gbenson at redhat dot com> ---
After having implemented this
(https://sourceware.org/ml/gdb-patches/2014-02/msg00398.html) I'm coming to the
conclusion that you can't rememdy this problem this way.

Here's an example where it can work:
  $ gdb /usr/lib64/libreoffice/program/soffice.bin 
  (gdb) start
  (gdb) b <Tab>

GDB tries to expand every symbol table.  With a limit of 1000 completions, GDB 
quickly hits the limit and returns control to the user.

Here's an example of where this method fails:
  $ gdb /usr/lib64/libreoffice/program/soffice.bin 
  (gdb) start
  (gdb) b m<Tab>

This list only has 875 candidates, but GDB still has to expand pretty much
every symbol table to root them all out.  A limit of 1000 here will not stop
the user seeing a lengthy pause.

I propose to continue discussing this issue as bug 11920, which refers to the
problem (namely that tab completion might stall the CLI without feedback)
rather than to this specific solution.

I will close this bug as RESOLVED INVALID in one week if nobody objects.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kratochvil at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[jan.kratochvil at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #10 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
I think you are hitting here the problem of Fedora debuginfo dwz PR 16405 which
I (or anyone) has not fixed yet.  On dwz debuginfo GDB has problem to resolve
just several symbols (in a backtrace) because it (needlessly) expands tons of
dwz-included CUs.

You should try it on debuginfo without dwz (such as RHEL-6 etc.).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #11 from Gary Benson <gbenson at redhat dot com> ---
As discussed on IRC, I'm using RHEL 6.5 so there should be no dwz.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Gary Benson <gbenson at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|gbenson at redhat dot com          |unassigned at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[maayan at maayank dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Maayan Keshet <maayan at maayank dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maayan at maayank dot com

--- Comment #12 from Maayan Keshet <maayan at maayank dot com> ---
Maybe it's difficult to resolve thoroughly, as the problem is the amount of
symbol tables and not amount of symbols (so it can happen with vastly varying
amount of symbols).

But for the meantime, can we have an option to disable the tab completion when
the inputted prefix is < $SOME_NUM? e.g. if I enter the command "noshorttab"
and do "b foo<tab>" nothing will happen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[manu at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #13 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Gary Benson from comment #9)
> After having implemented this
> (https://sourceware.org/ml/gdb-patches/2014-02/msg00398.html) I'm coming to
> the conclusion that you can't rememdy this problem this way.

At least you can alleviate it!

> This list only has 875 candidates, but GDB still has to expand pretty much
> every symbol table to root them all out.  A limit of 1000 here will not stop
> the user seeing a lengthy pause.

The two issues seem to be important to fix. And the issue here already has a
patch that is basically approved!

The problem is not only a lengthy pause (which is annoying but it is a
different issue), it is also that after the pause, Emacs may spend a several
*minutes* printing candidates, slowing the whole computer down with it. A limit
of 1000 seems almost too much, 150 or so seems much more manageable.

Please, can you commit your patch so at least there is some progress on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
>From gdb-prs-return-16752-listarch-gdb-prs=sources.redhat.com@sourceware.org Mon Sep 29 19:35:54 2014
Return-Path: <gdb-prs-return-16752-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-gdb-prs@sources.redhat.com
Received: (qmail 28481 invoked by alias); 29 Sep 2014 19:35:53 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Delivered-To: mailing list gdb-prs@sourceware.org
Received: (qmail 28449 invoked by uid 48); 29 Sep 2014 19:35:52 -0000
From: "jim.kearney at oracle dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug backtrace/16215] SPARC: can't compute CFA for this frame
Date: Mon, 29 Sep 2014 19:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: backtrace
X-Bugzilla-Version: 7.6
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jim.kearney at oracle dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-16215-4717-Q8Lr3g1v7M@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-16215-4717@http.sourceware.org/bugzilla/>
References: <bug-16215-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-q3/txt/msg00741.txt.bz2
Content-length: 399

https://sourceware.org/bugzilla/show_bug.cgi?id\x16215

Jim Kearney <jim.kearney at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jim.kearney at oracle dot com

--
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[gbenson at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #14 from Gary Benson <gbenson at redhat dot com> ---
New patch mailed:
https://sourceware.org/ml/gdb-patches/2014-11/msg00113.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[rscrihf+sourceware at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Roy Crihfield <rscrihf+sourceware at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rscrihf+sourceware at gmail dot co
                   |                            |m

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[yhager at yhager dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Yuval Hager <yhager at yhager dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yhager at yhager dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #15 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Doug Evans <devans@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ef0b411a110cd2602cb89c3fb237baf8beb28545

commit ef0b411a110cd2602cb89c3fb237baf8beb28545
Author: Gary Benson <gbenson@redhat.com>
Date:   Sat Jan 31 15:07:22 2015 -0800

    Add max-completions parameter, and implement tab-completion limiting.

    This commit adds a new exception, MAX_COMPLETIONS_REACHED_ERROR, to be
    thrown whenever the completer has generated too many candidates to
    be useful.  A new user-settable variable, "max_completions", is added
    to control this behaviour.  A top-level completion limit is added to
    complete_line_internal, as the final check to ensure the user never
    sees too many completions.  An additional limit is added to
    default_make_symbol_completion_list_break_on, to halt time-consuming
    symbol table expansions.

    gdb/ChangeLog:

        PR cli/9007
        PR cli/11920
        PR cli/15548
        * cli/cli-cmds.c (complete_command): Notify user if max-completions
        reached.
        * common/common-exceptions.h (enum errors)
        <MAX_COMPLETIONS_REACHED_ERROR>: New value.
        * completer.h (get_max_completions_reached_message): New declaration.
        (max_completions): Likewise.
        (completion_tracker_t): New typedef.
        (new_completion_tracker): New declaration.
        (make_cleanup_free_completion_tracker): Likewise.
        (maybe_add_completion_enum): New enum.
        (maybe_add_completion): New declaration.
        (throw_max_completions_reached_error): Likewise.
        * completer.c (max_completions): New global variable.
        (new_completion_tracker): New function.
        (free_completion_tracker): Likewise.
        (make_cleanup_free_completion_tracker): Likewise.
        (maybe_add_completions): Likewise.
        (throw_max_completions_reached_error): Likewise.
        (complete_line): Remove duplicates and limit result to max_completions
        entries.
        (get_max_completions_reached_message): New function.
        (gdb_display_match_list): Handle max_completions.
        (_initialize_completer): New declaration and function.
        * symtab.c: Include completer.h.
        (completion_tracker): New static variable.
        (completion_list_add_name): Call maybe_add_completion.
        (default_make_symbol_completion_list_break_on_1): Renamed from
        default_make_symbol_completion_list_break_on.  Maintain
        completion_tracker across calls to completion_list_add_name.
        (default_make_symbol_completion_list_break_on): New function.
        * top.c (init_main): Set rl_completion_display_matches_hook.
        * tui/tui-io.c: Include completer.h.
        (tui_old_rl_display_matches_hook): New static global.
        (tui_rl_display_match_list): Notify user if max-completions reached.
        (tui_setup_io): Save/restore rl_completion_display_matches_hook.
        * NEWS (New Options): Mention set/show max-completions.

    gdb/doc/ChangeLog:

        * gdb.texinfo (Command Completion): Document new
        "set/show max-completions" option.

    gdb/testsuite/ChangeLog:

        * gdb.base/completion.exp: Disable completion limiting for
        existing tests.  Add new tests to check completion limiting.
        * gdb.linespec/ls-errs.exp: Disable completion limiting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

--- Comment #16 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Doug Evans <devans@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cfb069a8bebfacaf00dee6446e86a856978670be

commit cfb069a8bebfacaf00dee6446e86a856978670be
Author: Gary Benson <gbenson@redhat.com>
Date:   Sat Jan 31 15:24:26 2015 -0800

    ChangeLog entries for max-completions patch.

    gdb/ChangeLog:

        PR cli/9007
        PR cli/11920
        PR cli/15548
        * cli/cli-cmds.c (complete_command): Notify user if max-completions
        reached.
        * common/common-exceptions.h (enum errors)
        <MAX_COMPLETIONS_REACHED_ERROR>: New value.
        * completer.h (get_max_completions_reached_message): New declaration.
        (max_completions): Likewise.
        (completion_tracker_t): New typedef.
        (new_completion_tracker): New declaration.
        (make_cleanup_free_completion_tracker): Likewise.
        (maybe_add_completion_enum): New enum.
        (maybe_add_completion): New declaration.
        (throw_max_completions_reached_error): Likewise.
        * completer.c (max_completions): New global variable.
        (new_completion_tracker): New function.
        (free_completion_tracker): Likewise.
        (make_cleanup_free_completion_tracker): Likewise.
        (maybe_add_completions): Likewise.
        (throw_max_completions_reached_error): Likewise.
        (complete_line): Remove duplicates and limit result to max_completions
        entries.
        (get_max_completions_reached_message): New function.
        (gdb_display_match_list): Handle max_completions.
        (_initialize_completer): New declaration and function.
        * symtab.c: Include completer.h.
        (completion_tracker): New static variable.
        (completion_list_add_name): Call maybe_add_completion.
        (default_make_symbol_completion_list_break_on_1): Renamed from
        default_make_symbol_completion_list_break_on.  Maintain
        completion_tracker across calls to completion_list_add_name.
        (default_make_symbol_completion_list_break_on): New function.
        * top.c (init_main): Set rl_completion_display_matches_hook.
        * tui/tui-io.c: Include completer.h.
        (tui_old_rl_display_matches_hook): New static global.
        (tui_rl_display_match_list): Notify user if max-completions reached.
        (tui_setup_io): Save/restore rl_completion_display_matches_hook.
        * NEWS (New Options): Mention set/show max-completions.

    gdb/doc/ChangeLog:

        * gdb.texinfo (Command Completion): Document new
        "set/show max-completions" option.

    gdb/testsuite/ChangeLog:

        * gdb.base/completion.exp: Disable completion limiting for
        existing tests.  Add new tests to check completion limiting.
        * gdb.linespec/ls-errs.exp: Disable completion limiting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[xdje42 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Doug Evans <xdje42 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |xdje42 at gmail dot com
         Resolution|---                         |FIXED

--- Comment #18 from Doug Evans <xdje42 at gmail dot com> ---
Patch committed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug cli/15548] Limit completions to a pre-defined limit when completions list is very large

[xdje42 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=15548

Doug Evans <xdje42 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcl441-bugs at yahoo dot com

--- Comment #17 from Doug Evans <xdje42 at gmail dot com> ---
*** Bug 11048 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.