public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/15678] Typing "enable count" crashes gdb
Date: Fri, 06 Feb 2015 15:33:00 -0000	[thread overview]
Message-ID: <bug-15678-4717-u4wAexTFB6@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15678-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=15678

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b9d6130764916fac3d9bcfde2d672053a0ef3316

commit b9d6130764916fac3d9bcfde2d672053a0ef3316
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Mon Feb 2 14:57:31 2015 -0500

    "enable count" user input error handling (PR gdb/15678)

    Typing "enable count" by itself crashes GDB. Also, if you omit the
    breakpoint number/range, the error message is not very clear:

    (gdb) enable count 2
    warning: bad breakpoint number at or near ''
    (gdb) enable count
    Segmentation fault (core dumped)

    With this patch, the error messages are slightly more helpful:

    (gdb) enable count 2
    Argument required (one or more breakpoint numbers).
    (gdb) enable count
    Argument required (hit count).

    gdb/ChangeLog:

        PR gdb/15678
        * breakpoint.c (map_breakpoint_numbers): Check for empty args
        string.
        (enable_count_command): Check args for NULL value.

    gdb/testsuite/ChangeLog:

        PR gdb/15678
        * gdb.base/ena-dis-br.exp: Test "enable count" for bad user input.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2015-02-06 15:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 22:09 [Bug gdb/15678] New: " simon.marchi at ericsson dot com
2013-08-05 16:20 ` [Bug gdb/15678] " jan.kratochvil at redhat dot com
2013-08-06 14:16 ` jan.kratochvil at redhat dot com
2013-08-06 18:43 ` palves at redhat dot com
2015-02-06 15:33 ` cvs-commit at gcc dot gnu.org [this message]
2015-02-06 18:07 ` simon.marchi at ericsson dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15678-4717-u4wAexTFB6@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).