From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-17435-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 807 invoked by alias); 6 Feb 2015 15:28:21 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 776 invoked by uid 55); 6 Feb 2015 15:28:20 -0000
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/15678] Typing "enable count" crashes gdb
Date: Fri, 06 Feb 2015 15:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: simon.marchi at ericsson dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-15678-4717-u4wAexTFB6@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-15678-4717@http.sourceware.org/bugzilla/>
References: <bug-15678-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q1/txt/msg00200.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=15678

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b9d6130764916fac3d9bcfde2d672053a0ef3316

commit b9d6130764916fac3d9bcfde2d672053a0ef3316
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Mon Feb 2 14:57:31 2015 -0500

    "enable count" user input error handling (PR gdb/15678)

    Typing "enable count" by itself crashes GDB. Also, if you omit the
    breakpoint number/range, the error message is not very clear:

    (gdb) enable count 2
    warning: bad breakpoint number at or near ''
    (gdb) enable count
    Segmentation fault (core dumped)

    With this patch, the error messages are slightly more helpful:

    (gdb) enable count 2
    Argument required (one or more breakpoint numbers).
    (gdb) enable count
    Argument required (hit count).

    gdb/ChangeLog:

        PR gdb/15678
        * breakpoint.c (map_breakpoint_numbers): Check for empty args
        string.
        (enable_count_command): Check args for NULL value.

    gdb/testsuite/ChangeLog:

        PR gdb/15678
        * gdb.base/ena-dis-br.exp: Test "enable count" for bad user input.

-- 
You are receiving this mail because:
You are on the CC list for the bug.