[Bug mi/15806] Some fields in async MI events get escaped twice

["simon.marchi at ericsson dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=15806

--- Comment #12 from Simon Marchi <simon.marchi at ericsson dot com> ---
Oops, yeah the fix was only for breakpoint-created, sorry about that.

Your comment made me realize that if a library path contains a quote ("), the
result will be wrong. Example:

=library-loaded,id="/tmp/hello"you/libpopt.so.0",target-name="/tmp/hello"you/libpopt.so.0",host-name="/tmp/hello"you/libpopt.so.0",symbols-loaded="0",thread-group="i1"

To reproduce this, I created '/tmp/hello"you', copied some library in it and
modified LD_LIBRARY_PATH so that my test program use this library instead of
the system's version. You can see that the " between hello and you is not
escaped, but should be.

I think that no escaping can be done reliably in gdb_flush. There is no way to
differentiate a quote that should not be escaped from one that should be
escaped. Therefore, I think it should always be done at the moment where the
content is created.

Also, using fprintf_unfiltered to output this is wrong, because the fields are
never escaped. It would probably be better to use the ui_out_field_* functions
everywhere. What do you think ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.