public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
* [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL @ 2013-08-05 7:47 jan.kratochvil at redhat dot com 2013-08-09 16:50 ` [Bug python/15816] " tromey at redhat dot com ` (4 more replies) 0 siblings, 5 replies; 6+ messages in thread From: jan.kratochvil at redhat dot com @ 2013-08-05 7:47 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=15816 Bug ID: 15816 Summary: python-selftest.exp false FAIL on RETURN_MASK_ALL Product: gdb Version: HEAD Status: NEW Severity: minor Priority: P2 Component: python Assignee: unassigned at sourceware dot org Reporter: jan.kratochvil at redhat dot com CC: pmuldoon at redhat dot com Host: x86_64-unknown-linux-gnu Target: x86_64-unknown-linux-gnu On CentOS-5 and CentOS-6 (both x86_64 and i386) I get: call catch_command_errors(execute_command, "python print 5", 0, RETURN_MASK_ALL) No symbol "RETURN_MASK_ALL" in current context. (gdb) FAIL: gdb.gdb/python-selftest.exp: call catch_command_errors(execute_command, "python print 5", 0, RETURN_MASK_ALL) This does not happen on any (recent) Fedoras. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug python/15816] python-selftest.exp false FAIL on RETURN_MASK_ALL 2013-08-05 7:47 [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL jan.kratochvil at redhat dot com @ 2013-08-09 16:50 ` tromey at redhat dot com 2013-08-09 17:21 ` tromey at redhat dot com ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: tromey at redhat dot com @ 2013-08-09 16:50 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=15816 Tom Tromey <tromey at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tromey at redhat dot com --- Comment #1 from Tom Tromey <tromey at redhat dot com> --- RETURN_MASK_ALL is a macro. It's interesting that this works anywhere. I think we can make RETURN_MASK_* into enum constants. That seems like the best fix to me. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug python/15816] python-selftest.exp false FAIL on RETURN_MASK_ALL 2013-08-05 7:47 [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL jan.kratochvil at redhat dot com 2013-08-09 16:50 ` [Bug python/15816] " tromey at redhat dot com @ 2013-08-09 17:21 ` tromey at redhat dot com 2013-08-09 17:25 ` jan.kratochvil at redhat dot com ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: tromey at redhat dot com @ 2013-08-09 17:21 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=15816 Tom Tromey <tromey at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at sourceware dot org |tromey at redhat dot com -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug python/15816] python-selftest.exp false FAIL on RETURN_MASK_ALL 2013-08-05 7:47 [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL jan.kratochvil at redhat dot com 2013-08-09 16:50 ` [Bug python/15816] " tromey at redhat dot com 2013-08-09 17:21 ` tromey at redhat dot com @ 2013-08-09 17:25 ` jan.kratochvil at redhat dot com 2013-08-20 15:12 ` cvs-commit at gcc dot gnu.org 2013-08-20 15:16 ` tromey at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: jan.kratochvil at redhat dot com @ 2013-08-09 17:25 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=15816 Jan Kratochvil <jan.kratochvil at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jan.kratochvil at redhat dot com --- Comment #2 from Jan Kratochvil <jan.kratochvil at redhat dot com> --- (In reply to Tom Tromey from comment #1) > RETURN_MASK_ALL is a macro. > It's interesting that this works anywhere. As an explanation my script uses -g3 only with recent GCCs. I sure agree with enum. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug python/15816] python-selftest.exp false FAIL on RETURN_MASK_ALL 2013-08-05 7:47 [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL jan.kratochvil at redhat dot com ` (2 preceding siblings ...) 2013-08-09 17:25 ` jan.kratochvil at redhat dot com @ 2013-08-20 15:12 ` cvs-commit at gcc dot gnu.org 2013-08-20 15:16 ` tromey at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2013-08-20 15:12 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=15816 --- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- CVSROOT: /cvs/src Module name: src Changes by: tromey@sourceware.org 2013-08-20 15:12:53 Modified files: gdb : ChangeLog exceptions.h Log message: fix PR python/15816 This fixes PR python/15816. The bug here is that python-selftest.exp can fail: No symbol "RETURN_MASK_ALL" in current context. RETURN_MASK_ALL is a macro, so if macros do not end up in the debuginfo (very typical) then the test fails. It seemed simplest to me to simply turn the RETURN_MASK_ defines into enum constants. This way they end up in the debuginfo and all is well. PR python/15816: * exceptions.h (return_mask): Now an enum. (RETURN_MASK_QUIT, RETURN_MASK_ERROR, RETURN_MASK_ALL): Now enum constants. Built and regtested on x86-64 Fedora 18. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15912&r2=1.15913 http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/exceptions.h.diff?cvsroot=src&r1=1.42&r2=1.43 -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug python/15816] python-selftest.exp false FAIL on RETURN_MASK_ALL 2013-08-05 7:47 [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL jan.kratochvil at redhat dot com ` (3 preceding siblings ...) 2013-08-20 15:12 ` cvs-commit at gcc dot gnu.org @ 2013-08-20 15:16 ` tromey at redhat dot com 4 siblings, 0 replies; 6+ messages in thread From: tromey at redhat dot com @ 2013-08-20 15:16 UTC (permalink / raw) To: gdb-prs http://sourceware.org/bugzilla/show_bug.cgi?id=15816 Tom Tromey <tromey at redhat dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Target Milestone|--- |7.7 --- Comment #4 from Tom Tromey <tromey at redhat dot com> --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-20 15:16 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-08-05 7:47 [Bug python/15816] New: python-selftest.exp false FAIL on RETURN_MASK_ALL jan.kratochvil at redhat dot com 2013-08-09 16:50 ` [Bug python/15816] " tromey at redhat dot com 2013-08-09 17:21 ` tromey at redhat dot com 2013-08-09 17:25 ` jan.kratochvil at redhat dot com 2013-08-20 15:12 ` cvs-commit at gcc dot gnu.org 2013-08-20 15:16 ` tromey at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).