public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c
@ 2013-09-16 21:07 hager-markus at gmx dot de
  2013-09-17  6:51 ` [Bug gdb/15960] " qiyao at gcc dot gnu.org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: hager-markus at gmx dot de @ 2013-09-16 21:07 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

            Bug ID: 15960
           Summary: Error during build gdb with MinGW on Windows -> util.c
           Product: gdb
           Version: 7.6
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdb
          Assignee: unassigned at sourceware dot org
          Reporter: hager-markus at gmx dot de

I tried to build GDB 7.6 (same error with 7.6.1) on Windows 7 using MinGW with
msys terminal. I changed none of the standard configuration, just unpacked
everything and performed ./configure and ./make

The problem occurred during compilation of file gdb-7.6\readline\util.c

I fixed a missing ; in line 392 (closed do-while-loop at end of
'_rl_strnicmp'-function).

Best regards,
Markus

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Bug gdb/15960] Error during build gdb with MinGW on Windows -> util.c
  2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
@ 2013-09-17  6:51 ` qiyao at gcc dot gnu.org
  2013-09-17  9:52 ` hager-markus at gmx dot de
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: qiyao at gcc dot gnu.org @ 2013-09-17  6:51 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |qiyao at gcc dot gnu.org

--- Comment #1 from Yao Qi <qiyao at gcc dot gnu.org> ---
Markus,
It would be useful to post the error message you got when you build GDB, and
the version of GCC you used, so that other people can reproduce the problem in
their env.

If you have a patch to fix the error, you can contribute it.  Please read
https://sourceware.org/gdb/wiki/ContributionChecklist for more details.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Bug gdb/15960] Error during build gdb with MinGW on Windows -> util.c
  2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
  2013-09-17  6:51 ` [Bug gdb/15960] " qiyao at gcc dot gnu.org
@ 2013-09-17  9:52 ` hager-markus at gmx dot de
  2013-09-17 10:27 ` qiyao at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: hager-markus at gmx dot de @ 2013-09-17  9:52 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

--- Comment #2 from hager-markus at gmx dot de ---
gcc version: 4.8.1

error message:
util.c: In function '_rl_strnicmp':
util.c:394:3: error: expected ';' before 'return'
    return (0);
    ^

I guess this occurs only during the build on windows because otherwise I
couldn't imagine why this error wasn't discovered earlier. By the way, if you
look into the util.c I think this error is quite obvious, or is there any case
where the ; could be missed?

Best regards,
Markus

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Bug gdb/15960] Error during build gdb with MinGW on Windows -> util.c
  2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
  2013-09-17  6:51 ` [Bug gdb/15960] " qiyao at gcc dot gnu.org
  2013-09-17  9:52 ` hager-markus at gmx dot de
@ 2013-09-17 10:27 ` qiyao at gcc dot gnu.org
  2013-09-17 10:44 ` asmwarrior at gmail dot com
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: qiyao at gcc dot gnu.org @ 2013-09-17 10:27 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

--- Comment #3 from Yao Qi <qiyao at gcc dot gnu.org> ---
(In reply to hager-markus from comment #2)
> gcc version: 4.8.1
> 
> error message:
> util.c: In function '_rl_strnicmp':
> util.c:394:3: error: expected ';' before 'return'
>     return (0);
>     ^
> 
> I guess this occurs only during the build on windows because otherwise I
> couldn't imagine why this error wasn't discovered earlier. By the way, if
> you look into the util.c I think this error is quite obvious, or is there
> any case where the ; could be missed?
> 

I am using i686-pc-mingw32-gcc to cross compile GDB for windows.  I didn't see
the error before.  This piece of code is surrounded by #if !defined
(HAVE_STRCASECMP) and #endif, HAVE_STRCASECMP is defined in my config.h.  This
piece of code is not compiled for me, and probably that is the reason why I
didn't see this error before.

GDB is using readline from
(http://cnswww.cns.cwru.edu/php/chet/readline/rltop.html).  Please report this
error to bug-readline@gnu.org, get it fixed, and then backport the fix to GDB.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Bug gdb/15960] Error during build gdb with MinGW on Windows -> util.c
  2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
                   ` (2 preceding siblings ...)
  2013-09-17 10:27 ` qiyao at gcc dot gnu.org
@ 2013-09-17 10:44 ` asmwarrior at gmail dot com
  2013-09-19 16:30 ` hager-markus at gmx dot de
  2014-02-16  1:45 ` qiyao at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: asmwarrior at gmail dot com @ 2013-09-17 10:44 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

asmwarrior <asmwarrior at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asmwarrior at gmail dot com

--- Comment #4 from asmwarrior <asmwarrior at gmail dot com> ---
I don't have such build error, I'm using msys1 and mingw-gcc 4.6.3 dw2 version.
Yuanhui Zhang

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Bug gdb/15960] Error during build gdb with MinGW on Windows -> util.c
  2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
                   ` (3 preceding siblings ...)
  2013-09-17 10:44 ` asmwarrior at gmail dot com
@ 2013-09-19 16:30 ` hager-markus at gmx dot de
  2014-02-16  1:45 ` qiyao at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: hager-markus at gmx dot de @ 2013-09-19 16:30 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

--- Comment #5 from hager-markus at gmx dot de ---
> Please report
> this error to bug-readline@gnu.org, get it fixed, and then backport the fix
> to GDB.

I received the following from the readline-team, so it is already fixed:

Thanks for the report. This was reported and fixed earlier. Adding the
semicolon is the right fix. This is a lightly-used piece of code
(obviously), so I probably will not release it as a patch. The gdb
developers can put in the straightforward fix and move forward.

Chet

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Bug gdb/15960] Error during build gdb with MinGW on Windows -> util.c
  2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
                   ` (4 preceding siblings ...)
  2013-09-19 16:30 ` hager-markus at gmx dot de
@ 2014-02-16  1:45 ` qiyao at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: qiyao at gcc dot gnu.org @ 2014-02-16  1:45 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=15960

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Yao Qi <qiyao at gcc dot gnu.org> ---
Patch was committed.  Close this PR.

2013-09-23  Martin Benda  <martin.benda@omsquare.com>

        Checked in by Joel Brobecker  <brobecker@adacore.com>
        * util.c (_rl_strnicmp): Add missing semicolon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-02-16  1:45 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-16 21:07 [Bug gdb/15960] New: Error during build gdb with MinGW on Windows -> util.c hager-markus at gmx dot de
2013-09-17  6:51 ` [Bug gdb/15960] " qiyao at gcc dot gnu.org
2013-09-17  9:52 ` hager-markus at gmx dot de
2013-09-17 10:27 ` qiyao at gcc dot gnu.org
2013-09-17 10:44 ` asmwarrior at gmail dot com
2013-09-19 16:30 ` hager-markus at gmx dot de
2014-02-16  1:45 ` qiyao at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).