public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug remote/15974] Unsupported notification packets are causing errors (last of the nc_list is picked).
Date: Mon, 02 Dec 2013 06:47:00 -0000	[thread overview]
Message-ID: <bug-15974-4717-86FFWsbhB0@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-15974-4717@http.sourceware.org/bugzilla/>

http://sourceware.org/bugzilla/show_bug.cgi?id=15974

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  62972e0b66f4247f56c795ee55bc0825933a7bed (commit)
      from  f9b0da3d5833ad5f809422f3084b0ef8fa5c5762 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=62972e0b66f4247f56c795ee55bc0825933a7bed

commit 62972e0b66f4247f56c795ee55bc0825933a7bed
Author: Yao Qi <yao@codesourcery.com>
Date:   Thu Aug 15 09:09:08 2013 +0800

    Fix PR remote/15974

    In remote-notif.c:handle_notification, we have a loop,

      for (i = 0; i < ARRAY_SIZE (notifs); i++)
        {
          nc = notifs[i];
          if (strncmp (buf, nc->name, strlen (nc->name)) == 0
          && buf[strlen (nc->name)] == ':')
        break;
        }

      /* We ignore notifications we don't recognize, for compatibility
         with newer stubs.  */
      if (nc == NULL)
        return;

    If the notification is not in the list 'notifs', the last entry is
    used, which is wrong.  It should be NULL.  This patch fixes it.

    gdb:

    2013-12-02  Pedro Alves  <palves@redhat.com>

        PR remote/15974
        * remote-notif.c (handle_notification): Return early if no
        notification is found.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog      |    6 ++++++
 gdb/remote-notif.c |   15 +++++++++------
 2 files changed, 15 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2013-12-02  6:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 14:14 [Bug corefiles/15974] New: " forum at emblocks dot org
2013-09-24  4:36 ` [Bug corefiles/15974] " forum at emblocks dot org
2013-09-24 10:12 ` qiyao at gcc dot gnu.org
2013-09-24 10:27 ` forum at emblocks dot org
2013-11-30  3:40 ` [Bug remote/15974] " qiyao at gcc dot gnu.org
2013-12-02  6:47 ` cvs-commit at gcc dot gnu.org [this message]
2013-12-02  6:55 ` qiyao at gcc dot gnu.org
2013-12-11  1:41 ` cvs-commit at gcc dot gnu.org
2013-12-13 16:52 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-15974-4717-86FFWsbhB0@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).