public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/15992] New: Invalid check of reboot_target return value in testsuite/config/monitor.exp
@ 2013-10-02 8:43 akolesov at synopsys dot com
0 siblings, 0 replies; only message in thread
From: akolesov at synopsys dot com @ 2013-10-02 8:43 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=15992
Bug ID: 15992
Summary: Invalid check of reboot_target return value in
testsuite/config/monitor.exp
Product: gdb
Version: HEAD
Status: NEW
Severity: normal
Priority: P2
Component: testsuite
Assignee: unassigned at sourceware dot org
Reporter: akolesov at synopsys dot com
CC: jeremy.bennett at embecosm dot com
Created attachment 7222
--> https://sourceware.org/bugzilla/attachment.cgi?id=7222&action=edit
Suggested patch
In gdb/testsuite/config/monitor.exp there are two conditions like:
if { ![reboot_target] }
However reboot_target returns an empty string on success and operation ! is not
allowed an empty string, TCL doesn't treat it implicitly as a "false". If I
understand everything properly then ![reboot_target] should be replaced with
[reboot_target] == "".
I've attached a suggested patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-10-02 8:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-02 8:43 [Bug testsuite/15992] New: Invalid check of reboot_target return value in testsuite/config/monitor.exp akolesov at synopsys dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).