public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug gdb/16014] New: Coding error: 2 * sizeof( sizeof())
@ 2013-10-08 7:53 dcb314 at hotmail dot com
2013-10-08 16:25 ` [Bug gdb/16014] " tromey at redhat dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2013-10-08 7:53 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=16014
Bug ID: 16014
Summary: Coding error: 2 * sizeof( sizeof())
Product: gdb
Version: 7.6
Status: NEW
Severity: normal
Priority: P2
Component: gdb
Assignee: unassigned at sourceware dot org
Reporter: dcb314 at hotmail dot com
I got the static analysis tool "cppcheck" to say
[gdb-7.6.1/gdb/dwarf2read.c:2970]: (warning) Calling 'sizeof' on 'sizeof'.
[gdb-7.6.1/gdb/gdbserver/tracepoint.c:5994]: (warning) Calling 'sizeof' on
'sizeof'.
Suggest remove one of the sizeofs, in each case.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug gdb/16014] Coding error: 2 * sizeof( sizeof())
2013-10-08 7:53 [Bug gdb/16014] New: Coding error: 2 * sizeof( sizeof()) dcb314 at hotmail dot com
@ 2013-10-08 16:25 ` tromey at redhat dot com
2013-10-08 17:33 ` dcb314 at hotmail dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: tromey at redhat dot com @ 2013-10-08 16:25 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=16014
Tom Tromey <tromey at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at redhat dot com
--- Comment #1 from Tom Tromey <tromey at redhat dot com> ---
It would be more convenient if you ran cppcheck against cvs head.
The line numbers are different there...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug gdb/16014] Coding error: 2 * sizeof( sizeof())
2013-10-08 7:53 [Bug gdb/16014] New: Coding error: 2 * sizeof( sizeof()) dcb314 at hotmail dot com
2013-10-08 16:25 ` [Bug gdb/16014] " tromey at redhat dot com
@ 2013-10-08 17:33 ` dcb314 at hotmail dot com
2013-10-16 2:55 ` cvs-commit at gcc dot gnu.org
2013-10-16 2:58 ` sergiodj at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: dcb314 at hotmail dot com @ 2013-10-08 17:33 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=16014
--- Comment #2 from dcb <dcb314 at hotmail dot com> ---
>It would be more convenient if you ran cppcheck against cvs head.
Maybe, or you could have a look at the gdb-7.6.1 that I reported
the problems against.
More of a clue for the first one:
qfn->real_names = OBSTACK_CALLOC (&objfile->objfile_obstack,
qfn->num_file_names, sizeof (char *));
I am guessing that removing the mention of sizeof will help.
For the second:
write_inferior_data_ptr
(actions_array + i * sizeof (sizeof (*tpoint->actions)),
ipa_action);
Here another removal of a sizeof looks plausible.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug gdb/16014] Coding error: 2 * sizeof( sizeof())
2013-10-08 7:53 [Bug gdb/16014] New: Coding error: 2 * sizeof( sizeof()) dcb314 at hotmail dot com
2013-10-08 16:25 ` [Bug gdb/16014] " tromey at redhat dot com
2013-10-08 17:33 ` dcb314 at hotmail dot com
@ 2013-10-16 2:55 ` cvs-commit at gcc dot gnu.org
2013-10-16 2:58 ` sergiodj at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2013-10-16 2:55 UTC (permalink / raw)
To: gdb-prs
http://sourceware.org/bugzilla/show_bug.cgi?id=16014
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
CVSROOT: /cvs/src
Module name: src
Changes by: sergiodj@sourceware.org 2013-10-16 02:55:27
Modified files:
gdb : ChangeLog dwarf2read.c
gdb/gdbserver : ChangeLog tracepoint.c
Log message:
There were two functions who were calling "sizeof" twice.
The first one, dw2_get_real_path from gdb/dwarf2read.c, was actually
making use of OBSTACK_CALLOC which already calls "sizeof" for its third
argument.
The second, download_tracepoint_1 from gdb/gdbserver/tracepoint.c, was
explicitly calling "sizeof" inside another "sizeof".
This patch fixed both functions.
gdb/ChangeLog
2013-10-16 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/16014
* dwarf2read.c (dw2_get_real_path): Remove unnecessary call to
sizeof.
gdb/gdbserver/ChangeLog
2013-10-16 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/16014
* tracepoint.c (download_tracepoint_1): Remove unnecessary double
call to sizeof.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.16104&r2=1.16105
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&r1=1.843&r2=1.844
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/ChangeLog.diff?cvsroot=src&r1=1.776&r2=1.777
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/gdbserver/tracepoint.c.diff?cvsroot=src&r1=1.83&r2=1.84
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug gdb/16014] Coding error: 2 * sizeof( sizeof())
2013-10-08 7:53 [Bug gdb/16014] New: Coding error: 2 * sizeof( sizeof()) dcb314 at hotmail dot com
` (2 preceding siblings ...)
2013-10-16 2:55 ` cvs-commit at gcc dot gnu.org
@ 2013-10-16 2:58 ` sergiodj at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: sergiodj at redhat dot com @ 2013-10-16 2:58 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=16014
Sergio Durigan Junior <sergiodj at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |sergiodj at redhat dot com
Resolution|--- |FIXED
--- Comment #4 from Sergio Durigan Junior <sergiodj at redhat dot com> ---
Fixed. Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-16 2:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-08 7:53 [Bug gdb/16014] New: Coding error: 2 * sizeof( sizeof()) dcb314 at hotmail dot com
2013-10-08 16:25 ` [Bug gdb/16014] " tromey at redhat dot com
2013-10-08 17:33 ` dcb314 at hotmail dot com
2013-10-16 2:55 ` cvs-commit at gcc dot gnu.org
2013-10-16 2:58 ` sergiodj at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).