public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "dcb314 at hotmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/16014] Coding error: 2 * sizeof( sizeof())
Date: Tue, 08 Oct 2013 17:33:00 -0000	[thread overview]
Message-ID: <bug-16014-4717-dwTlABvNNb@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-16014-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=16014

--- Comment #2 from dcb <dcb314 at hotmail dot com> ---
>It would be more convenient if you ran cppcheck against cvs head.

Maybe, or you could have a look at the gdb-7.6.1 that I reported
the problems against.

More of a clue for the first one:

    qfn->real_names = OBSTACK_CALLOC (&objfile->objfile_obstack,
                      qfn->num_file_names, sizeof (char *));

I am guessing that removing the mention of sizeof will help.

For the second:

        write_inferior_data_ptr
          (actions_array + i * sizeof (sizeof (*tpoint->actions)),
           ipa_action);

Here another removal of a sizeof looks plausible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


  parent reply	other threads:[~2013-10-08 17:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08  7:53 [Bug gdb/16014] New: " dcb314 at hotmail dot com
2013-10-08 16:25 ` [Bug gdb/16014] " tromey at redhat dot com
2013-10-08 17:33 ` dcb314 at hotmail dot com [this message]
2013-10-16  2:55 ` cvs-commit at gcc dot gnu.org
2013-10-16  2:58 ` sergiodj at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-16014-4717-dwTlABvNNb@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).