From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-14614-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 15055 invoked by alias); 5 Nov 2013 14:45:51 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 15028 invoked by uid 48); 5 Nov 2013 14:45:50 -0000
From: "mbilal at codesourcery dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug cli/16122] New: Unify interactivity tests to use
 input_from_terminal_p
Date: Tue, 05 Nov 2013 14:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: cli
X-Bugzilla-Version: 7.6
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mbilal at codesourcery dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter
Message-ID: <bug-16122-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-q4/txt/msg00240.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=16122

            Bug ID: 16122
           Summary: Unify interactivity tests to use input_from_terminal_p
           Product: gdb
           Version: 7.6
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
          Assignee: unassigned at sourceware dot org
          Reporter: mbilal at codesourcery dot com

On Mon, 01 Apr 2013 16:15:11 +0200, Pedro Alves wrote on gdb-patches 
> We don't add commands to history unless we're interactive debugging:
> 
>   /* Add line to history if appropriate.  */
>   if (instream == stdin
>       && ISATTY (stdin) && *linebuffer)
>     add_history (linebuffer);
+
> Probably, it'd be best to use input_from_terminal_p, which also
> checks for --batch mode, among other things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.