public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "js at sig21 dot net" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug breakpoints/16263] New: breakpoints on BL instruction in Thumb broken Date: Wed, 27 Nov 2013 12:47:00 -0000 [thread overview] Message-ID: <bug-16263-4717@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=16263 Bug ID: 16263 Summary: breakpoints on BL instruction in Thumb broken Product: gdb Version: unknown Status: NEW Severity: normal Priority: P2 Component: breakpoints Assignee: unassigned at sourceware dot org Reporter: js at sig21 dot net For the ARM target, commit 177321bd85d5a3d4ca05d320696d8af43bc0fc05 (Daniel Jacobowitz, Mon Feb 1 16:13:17 2010), which added Thumb2 breakpoint support, broke breakpoints set on the BL instruction in Thumb mode (and thus single stepping through Thumb code). arm_breakpoint_from_pc() inserts tdep->thumb2_breakpoint instead of tdep->thumb_breakpoint because the length of the BL instruction is 32bit (two 16bit instructions). The code has this: + /* If we have a separate 32-bit breakpoint instruction for Thumb-2, + check whether we are replacing a 32-bit instruction. */ + if (tdep->thumb2_breakpoint != NULL) but tdep->thumb2_breakpoint is set unconditionally in arm_linux_init_abi(). I confirmed that commenting out // tdep->thumb2_breakpoint = arm_linux_thumb2_le_breakpoint; works around the issue. It seems the assignment should be made depending on whether the target actually has Thumb2 support. -- You are receiving this mail because: You are on the CC list for the bug.
reply other threads:[~2013-11-27 12:47 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-16263-4717@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).