From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-15272-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 18590 invoked by alias); 24 Feb 2014 13:02:53 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 18563 invoked by uid 48); 24 Feb 2014 13:02:53 -0000
From: "pmuldoon at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug python/16324] py-finishbreakpoint.c incorrect frame_id_eq
Date: Mon, 24 Feb 2014 13:02:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: python
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pmuldoon at redhat dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: pmuldoon at redhat dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cc assigned_to
Message-ID: <bug-16324-4717-hqicC63qMl@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-16324-4717@http.sourceware.org/bugzilla/>
References: <bug-16324-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-q1/txt/msg00280.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=16324

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pmuldoon at redhat dot com
           Assignee|unassigned at sourceware dot org   |pmuldoon at redhat dot com

--- Comment #1 from Phil Muldoon <pmuldoon at redhat dot com> ---
It seems the correct test here is to use frame_id_p which checks if a valid
stack is found (with a simple check to frame_id.stack_status !=
FID_STACK_INVALID). It also checks the frame_id is not an outer frame id.

There is no explicit check for a null_frame_id, which I found odd. get_frame_id
can return a null_frame_id, but lots of callers don't check the return so there
is a latent bug there too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.