[Bug python/16486] New: differences between "bt" and "bt no-filters"

[Bug python/16486] New: differences between "bt" and "bt no-filters"

[tromey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16486

            Bug ID: 16486
           Summary: differences between "bt" and "bt no-filters"
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at redhat dot com

While working on a frame filter I noticed some output differences
between "bt" and "bt no-filters".  I think that if there is
a "null" filter (that just passes through the FrameDecorator objects),
then there should, ideally, be no differences between the two
cases.

Here's a frame from "bt":

#0  0x0000000000402f10 in on_generic_marshaller_1 (obj=0x615500 [Test],
v_schar=42 '*', v_uchar=43 '+', v_int=4096, v_long=8192, v_pointer=0x0,
v_double=0.5, v_float=5.5, user_data=0x0) at signals.c:400

The same frame from "bt no-filters":

#0  on_generic_marshaller_1 (obj=0x615500 [Test], v_schar=42 '*', 
    v_uchar=43 '+', v_int=4096, v_long=8192, v_pointer=0x0, v_double=0.5, 
    v_float=5.5, user_data=0x0) at signals.c:400

It may not be totally obvious here; but if you construct a test case
and make your terminal very large, you can see that the filtering
code prints the entire frame as a single long line.

The no-filter code still wraps; perhaps this is a separate bug (since
the screen size changed I would assume gdb would notice); but in any
case the wrapping and indentation looks nicer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/16486] differences between "bt" and "bt no-filters"

[pmuldoon at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16486

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmuldoon at redhat dot com

--- Comment #1 from Phil Muldoon <pmuldoon at redhat dot com> ---
I've added the missing wrap hints in the same places as the "no-filter" option.
 I will submit that soon.  However, I also noticed that for the first frame,
the "no-filter" option does not print an address, but the frame filtered
version does.

I looked into this, and if the sal.pc == current_frame.pc then the address is
not printed.

(This is the line in GDB)

Breakpoint 2, frame_show_address (frame=0x101ad50, sal=...) at
../../binutils-gdb/gdb/stack.c:146
146      return get_frame_pc (frame) != sal.pc;

I thought about fixing this, but I think it is somewhat of an arbitrary
decision for GDB to make over the frame filters.  After all, each frame filter
can either choose to show whatever address on whatever line it chooses.

So I decided not to fix that.  What do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/16486] differences between "bt" and "bt no-filters"

[pmuldoon at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16486

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |pmuldoon at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/16486] differences between "bt" and "bt no-filters"

[tromey at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16486

--- Comment #2 from Tom Tromey <tromey at redhat dot com> ---
(In reply to Phil Muldoon from comment #1)

> I thought about fixing this, but I think it is somewhat of an arbitrary
> decision for GDB to make over the frame filters.  After all, each frame
> filter can either choose to show whatever address on whatever line it
> chooses.
> 
> So I decided not to fix that.  What do you think?

I think your decision seems reasonable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/16486] differences between "bt" and "bt no-filters"

[pmuldoon at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=16486

Phil Muldoon <pmuldoon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.