public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/16678] record problem with recursion
Date: Fri, 21 Oct 2022 10:49:48 +0000	[thread overview]
Message-ID: <bug-16678-4717-meeNAYPihC@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-16678-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=16678

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Bruno Larsen <blarsen@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1f3e37e057e876b37db49dbd8ed5ca22c33f6772

commit 1f3e37e057e876b37db49dbd8ed5ca22c33f6772
Author: Bruno Larsen <blarsen@redhat.com>
Date:   Wed May 25 15:02:47 2022 -0300

    gdb/reverse: Fix stepping over recursive functions

    Currently, when using GDB to do reverse debugging, if we try to use the
    command "reverse next" to skip a recursive function, instead of skipping
    all of the recursive calls and stopping in the previous line, we stop at
    the second to last recursive call, and need to manually step backwards
    until we leave the first call.  This is well documented in PR gdb/16678.

    This bug happens because when GDB notices that a reverse step has
    entered into a function, GDB will add a step_resume_breakpoint at the
    start of the function, then single step out of the prologue once that
    breakpoint is hit.  The problem was happening because GDB wouldn't give
    that step_resume_breakpoint a frame-id, so the first time the breakpoint
    was hit, the inferior would be stopped.  This is fixed by giving the
    current frame-id to the breakpoint.

    This commit also changes gdb.reverse/step-reverse.c to contain a
    recursive function and attempt to both, skip it altogether, and to skip
    the second call from inside the first call, as this setup broke a
    previous version of the patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2022-10-21 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09 11:45 [Bug gdb/16678] New: " vicshen at gmail dot com
2022-10-21 10:49 ` [Bug gdb/16678] " cvs-commit at gcc dot gnu.org
2022-10-21 10:49 ` cvs-commit at gcc dot gnu.org [this message]
2022-10-21 10:52 ` blarsen at redhat dot com
2023-01-25 12:27 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-16678-4717-meeNAYPihC@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).