From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21801 invoked by alias); 4 Jun 2014 12:59:00 -0000 Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-prs-owner@sourceware.org Received: (qmail 21772 invoked by uid 55); 4 Jun 2014 12:58:59 -0000 From: "cvs-commit at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug breakpoints/17000] user breakpoint not inserted if software-single-step at same location Date: Wed, 04 Jun 2014 12:59:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: breakpoints X-Bugzilla-Version: 7.7 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: 7.8 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-q2/txt/msg00373.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=17000 --- Comment #5 from cvs-commit at gcc dot gnu.org --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "gdb and binutils". The branch, master has been updated via 03388bb71c1a1d1c613bb963f3d9287cfd100138 (commit) from ac21917f6bef764c73323c8117d293b5f6c70228 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=03388bb71c1a1d1c613bb963f3d9287cfd100138 commit 03388bb71c1a1d1c613bb963f3d9287cfd100138 Author: Yao Qi Date: Wed Jun 4 13:03:19 2014 +0800 Tweak sss-bp-on-user-bp.exp sss-bp-on-user-bp.c has an assumption that write to integer can be compiled to a single instruction, which isn't true on some arch, such as arm. This test requires setting two breakpoints on two consecutive instructions, so this patch is to get the address of the next instruction via disassemble and set the 2nd breakpoint there. This approach is portable. This patch fixes the fails in sss-bp-on-user-bp.exp on arm-none-abi target. There is no change in x86 test results. I also revert the patch to PR breakpoints/17000, and verified that the patched sss-bp-on-user-bp.exp still trigger the fail on x86-with-software-single-step. gdb/testsuite: 2014-06-04 Yao Qi * gdb.base/sss-bp-on-user-bp.c (main): Remove comments. * gdb.base/sss-bp-on-user-bp.exp: Don't set breakpoint on "set bar break here". Get the next instruction address and set breakpoint there. Remove "bar break" from the regexp patterns. ----------------------------------------------------------------------- Summary of changes: gdb/testsuite/gdb.base/sss-bp-on-user-bp.c | 4 ++-- gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp | 20 +++++++++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug.