public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "dje at google dot com" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug symtab/17003] New: default_iterate_over_objfiles_in_search_order: broken code or broken comment? Date: Fri, 30 May 2014 20:45:00 -0000 [thread overview] Message-ID: <bug-17003-4717@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=17003 Bug ID: 17003 Summary: default_iterate_over_objfiles_in_search_order: broken code or broken comment? Product: gdb Version: HEAD Status: NEW Severity: normal Priority: P2 Component: symtab Assignee: unassigned at sourceware dot org Reporter: dje at google dot com Which is right, the function comment or the implementation? If I ignore both and go with what I think the default should be, current_objfile should be searched first, and then we should iterate over all objfiles (ignoring current_objfile - already searched). objfiles.c: /* The default implementation for the "iterate_over_objfiles_in_search_order" gdbarch method. It is equivalent to use the ALL_OBJFILES macro, searching the objfiles in the order they are stored internally, ignoring CURRENT_OBJFILE. On most platorms, it should be close enough to doing the best we can without some knowledge specific to the architecture. */ void default_iterate_over_objfiles_in_search_order (struct gdbarch *gdbarch, iterate_over_objfiles_in_search_order_cb_ftype *cb, void *cb_data, struct objfile *current_objfile) { int stop = 0; struct objfile *objfile; ALL_OBJFILES (objfile) { stop = cb (objfile, cb_data); if (stop) return; } } -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2014-05-30 20:45 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-30 20:45 dje at google dot com [this message] 2023-03-04 18:47 ` [Bug symtab/17003] " tromey at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-17003-4717@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).