[Bug cli/17222] printf_filtered vs printf_unfiltered

["xdje42 at gmail dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17222

Doug Evans <xdje42 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xdje42 at gmail dot com

--- Comment #1 from Doug Evans <xdje42 at gmail dot com> ---
infcmd.c:signal_command is another example of an odd mix of printf_filtered and
printf_unfiltered:

  if (!non_stop)
    {
      struct thread_info *tp;
      ptid_t resume_ptid;
      int must_confirm = 0;

      /* This indicates what will be resumed.  Either a single thread,          
         a whole process, or all threads of all processes.  */
      resume_ptid = user_visible_resume_ptid (0);

      ALL_NON_EXITED_THREADS (tp)
        {
          if (ptid_equal (tp->ptid, inferior_ptid))
            continue;
          if (!ptid_match (tp->ptid, resume_ptid))
            continue;

          if (tp->suspend.stop_signal != GDB_SIGNAL_0
              && signal_pass_state (tp->suspend.stop_signal))
            {
              if (!must_confirm)
                printf_unfiltered (_("Note:\n"));
              printf_unfiltered (_("  Thread %d previously stopped with signal
%s, %s.\n"),
                                 tp->num,
                                 gdb_signal_to_name (tp->suspend.stop_signal),
                                 gdb_signal_to_string
(tp->suspend.stop_signal));
              must_confirm = 1;
            }
        }

      if (must_confirm
          && !query (_("Continuing thread %d (the current thread) with
specified signal will\n"
                       "still deliver the signals noted above to their
respective threads.\n"
                       "Continue anyway? "),
                     inferior_thread ()->num))
        error (_("Not confirmed."));
    }

  if (from_tty)
    {
      if (oursig == GDB_SIGNAL_0)
        printf_filtered (_("Continuing with no signal.\n"));
      else
        printf_filtered (_("Continuing with signal %s.\n"),
                         gdb_signal_to_name (oursig));
    }

-- 
You are receiving this mail because:
You are on the CC list for the bug.