From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13334 invoked by alias); 31 Aug 2014 22:11:36 -0000 Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-prs-owner@sourceware.org Received: (qmail 13185 invoked by uid 48); 31 Aug 2014 22:11:32 -0000 From: "xdje42 at gmail dot com" To: gdb-prs@sourceware.org Subject: [Bug cli/17222] printf_filtered vs printf_unfiltered Date: Sun, 31 Aug 2014 22:11:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: cli X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: xdje42 at gmail dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-q3/txt/msg00381.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=17222 Doug Evans changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xdje42 at gmail dot com --- Comment #1 from Doug Evans --- infcmd.c:signal_command is another example of an odd mix of printf_filtered and printf_unfiltered: if (!non_stop) { struct thread_info *tp; ptid_t resume_ptid; int must_confirm = 0; /* This indicates what will be resumed. Either a single thread, a whole process, or all threads of all processes. */ resume_ptid = user_visible_resume_ptid (0); ALL_NON_EXITED_THREADS (tp) { if (ptid_equal (tp->ptid, inferior_ptid)) continue; if (!ptid_match (tp->ptid, resume_ptid)) continue; if (tp->suspend.stop_signal != GDB_SIGNAL_0 && signal_pass_state (tp->suspend.stop_signal)) { if (!must_confirm) printf_unfiltered (_("Note:\n")); printf_unfiltered (_(" Thread %d previously stopped with signal %s, %s.\n"), tp->num, gdb_signal_to_name (tp->suspend.stop_signal), gdb_signal_to_string (tp->suspend.stop_signal)); must_confirm = 1; } } if (must_confirm && !query (_("Continuing thread %d (the current thread) with specified signal will\n" "still deliver the signals noted above to their respective threads.\n" "Continue anyway? "), inferior_thread ()->num)) error (_("Not confirmed.")); } if (from_tty) { if (oursig == GDB_SIGNAL_0) printf_filtered (_("Continuing with no signal.\n")); else printf_filtered (_("Continuing with signal %s.\n"), gdb_signal_to_name (oursig)); } -- You are receiving this mail because: You are on the CC list for the bug.