public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "dje at google dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/17388] New: Allow DW_FORM_GNU_addr_index in Fission skeleton CUs
Date: Fri, 12 Sep 2014 23:43:00 -0000	[thread overview]
Message-ID: <bug-17388-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=17388

            Bug ID: 17388
           Summary: Allow DW_FORM_GNU_addr_index in Fission skeleton CUs
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: dje at google dot com

gdb currently flags an error for DW_FORM_GNU_addr_index appearing in Fission
skeleton CUs.
There's no need for this restriction.

2014-09-12  Doug Evans  <dje@google.com>

        * dwarf2read.c (read_attribute_value): Allow DW_FORM_GNU_addr_index
        in Fission skeleton CUs.

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index be32309..430a945 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -16077,14 +16077,6 @@ read_attribute_value (const struct die_reader_specs
*reader,
       info_ptr = read_attribute_value (reader, attr, form, info_ptr);
       break;
     case DW_FORM_GNU_addr_index:
-      if (reader->dwo_file == NULL)
-       {
-         /* For now flag a hard error.
-            Later we can turn this into a complaint.  */
-         error (_("Dwarf Error: %s found in non-DWO CU [in module %s]"),
-                dwarf_form_name (form),
-                bfd_get_filename (abfd));
-       }
       DW_ADDR (attr) = read_addr_index_from_leb128 (cu, info_ptr,
&bytes_read);
       info_ptr += bytes_read;
       break;

-- 
You are receiving this mail because:
You are on the CC list for the bug.


             reply	other threads:[~2014-09-12 23:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 23:43 dje at google dot com [this message]
2014-09-12 23:43 ` [Bug symtab/17388] " dje at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-17388-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).