[Bug gdb/17416] -var-list-children fails with "set print object on" and invalid/NULL value

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17416

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f7e5394d614db4456fc0d9598bbfa936cc7941af

commit f7e5394d614db4456fc0d9598bbfa936cc7941af
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Fri Jan 23 12:59:24 2015 -0500

    Catch exception in value_rtti_indirect_type

    In the situation described in bug 17416 [1]:

      * "set print object" is on;
      * The variable object is a pointer to a struct, and it contains an
        invalid value (e.g. NULL, or random uninitialized value);
      * The variable object (struct) has a child which is also a pointer to a
        struct;
      * We try to use "-var-list-children".

    ... an exception thrown in value_ind can propagate too far and leave an
    half-built variable object, leading to a wrong state. This patch adds a
    TRY_CATCH to catch it and makes value_rtti_indirect_type return NULL in
    that case, meaning that the type of the pointed object could not be
    found.

    A test for the fix is also added.

    New in v2:

      * Added test.
      * Restructured "catch" code.
      * Added details about the bug in commit log.

    gdb/Changelog:

        * valops.c (value_rtti_indirect_type): Catch exception thrown by
        value_ind.

    gdb/testsuite/ChangeLog

        * gdb.mi/mi-var-list-children-invalid-grandchild.c: New file.
        * gdb.mi/mi-var-list-children-invalid-grandchild.exp: New file.

    [1] https://sourceware.org/bugzilla/show_bug.cgi?id=17416

-- 
You are receiving this mail because:
You are on the CC list for the bug.