[Bug server/17457] New: aarch64/gdbserver: wrong floating point registers display

[Bug server/17457] New: aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

            Bug ID: 17457
           Summary: aarch64/gdbserver: wrong floating point registers
                    display
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: server
          Assignee: unassigned at sourceware dot org
          Reporter: catalin.udma at freescale dot com

When using aarch64 gdb with gdbserver, floating point registers are
not correctly displayed, as below:
  (gdb) info registers fpsr fpcr
  fpsr           <unavailable>
  fpcr           <unavailable>

Also, the offset for floating point v0-v31 registers in gdbserver
is wrong because of the CPSR register size mismatch between gdb and gdbserver.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

Catalin Udma <catalin.udma at freescale dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |catalin.udma at freescale dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |palves at redhat dot com
         Resolution|---                         |FIXED
   Target Milestone|---                         |7.9

--- Comment #1 from Pedro Alves <palves at redhat dot com> ---
This is fixed in both master and 7.8.1, by:

commit bdc144174bcb11e808b4e73089b850cf9620a7ee
...
    Aarch64: Make CPSR a 32-bit register again in the target description

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #2 from Catalin Udma <catalin.udma at freescale dot com> ---
Hi,

Actually in the bug I described two problems:
- one is wrong v0-v31 offset -> this is fixed in bdc1441
- the second is that fpsr and fpcr registers are missing: this is fixed in
bdc1441 + the patch I sent (aarch64/gdbserver: fix floating point registers
display)

Regards,
Catalin

> -----Original Message-----
> From: gdb-prs-owner@sourceware.org [mailto:gdb-prs-owner@sourceware.org]
> On Behalf Of palves at redhat dot com
> Sent: Monday, October 06, 2014 5:12 PM
> To: gdb-prs@sourceware.org
> Subject: [Bug server/17457] aarch64/gdbserver: wrong floating point
> registers display
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=17457
> 
> Pedro Alves <palves at redhat dot com> changed:
> 
>            What    |Removed                     |Added
> -------------------------------------------------------------------------
> ---
>              Status|NEW                         |RESOLVED
>                  CC|                            |palves at redhat dot com
>          Resolution|---                         |FIXED
>    Target Milestone|---                         |7.9
> 
> --- Comment #1 from Pedro Alves <palves at redhat dot com> ---
> This is fixed in both master and 7.8.1, by:
> 
> commit bdc144174bcb11e808b4e73089b850cf9620a7ee
> ...
>     Aarch64: Make CPSR a 32-bit register again in the target description
> 
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

Pedro Alves <palves at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from Pedro Alves <palves at redhat dot com> ---
Ah.  Is that patch in already?

This looks like something it'd be nice to have a testcase for.  Like, the
program would setup the floating point registers in some way (like v0=1, v1=2,
etc.) and then printing them from GDB should result in the expected values. 
And then for fpsr/fpcr we should be able to test that at least a number comes
out...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #4 from Catalin Udma <catalin.udma at freescale dot com> ---
This is the patch:
https://sourceware.org/ml/gdb-patches/2014-08/msg00496.html 

And this is the latest approval for the patch
https://sourceware.org/ml/gdb-patches/2014-09/msg00053.html
I assumed it will be pushed as it is.

Then should I submit a new patch with the testcase for v0..fpsr/fpcr?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[palves at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #5 from Pedro Alves <palves at redhat dot com> ---
Yes, if you could send an updated patch that no longer references the
aarch64.dat issue in the commit log, it'd be great.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #6 from Catalin Udma <catalin.udma at freescale dot com> ---
> if you could send an updated patch that no longer references the aarch64.dat issue in the commit log, it'd be great.
 Already done: the patch I mentioned is v2 - this removes any reference to
aarch64.dat

I'll send the patch with the testcase soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #7 from Catalin Udma <catalin.udma at freescale dot com> ---
Sent for review the testcase:
https://sourceware.org/ml/gdb-patches/2014-10/msg00147.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  bf330350c212fb8880faab663f5b3565319d0a95 (commit)
      from  8fda9068191372d8282648986055493be17feff0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bf330350c212fb8880faab663f5b3565319d0a95

commit bf330350c212fb8880faab663f5b3565319d0a95
Author: Catalin Udma <catalin.udma@freescale.com>
Date:   Tue Dec 16 09:51:42 2014 +0200

    aarch64/gdbserver: fix floating point registers display

    When using aarch64 gdb with gdbserver, floating point registers are
    not correctly displayed, as below:
      (gdb) info registers fpsr fpcr
      fpsr           <unavailable>
      fpcr           <unavailable>

    To fix these problems, the missing fpsr and fpcr registers are added
    when floating point registers are read/write
    Add test for aarch64 floating point
    PR server/17457

    gdb/gdbserver/

        PR server/17457
        * linux-aarch64-low.c (AARCH64_FPSR_REGNO): New define.
        (AARCH64_FPCR_REGNO): Likewise.
        (AARCH64_NUM_REGS): Update to include fpsr/fpcr registers.
        (aarch64_fill_fpregset): Add missing fpsr/fpcr registers.
        (aarch64_store_fpregset): Likewise.

    gdb/testsuite/

        PR server/17457
        * gdb.arch/aarch64-fp.c: New file.
        * gdb.arch/aarch64-fp.exp: New file.

    Signed-off-by: Catalin Udma <catalin.udma@freescale.com>

-----------------------------------------------------------------------

Summary of changes:
 gdb/gdbserver/ChangeLog               |    9 ++++
 gdb/gdbserver/linux-aarch64-low.c     |    8 +++-
 gdb/testsuite/ChangeLog               |    6 ++
 gdb/testsuite/gdb.arch/aarch64-fp.c   |   38 +++++++++++++++
 gdb/testsuite/gdb.arch/aarch64-fp.exp |   85 +++++++++++++++++++++++++++++++++
 5 files changed, 145 insertions(+), 1 deletions(-)
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-fp.c
 create mode 100644 gdb/testsuite/gdb.arch/aarch64-fp.exp

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |qiyao at gcc dot gnu.org

--- Comment #9 from Yao Qi <qiyao at gcc dot gnu.org> ---
We can close it, can't we?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[catalin.udma at freescale dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

--- Comment #10 from Catalin Udma <catalin.udma at freescale dot com> ---
We can close it. The above commit fixed the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Yao Qi <qiyao at gcc dot gnu.org> ---
Close it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug server/17457] aarch64/gdbserver: wrong floating point registers display

[jmgao at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17457

Josh Gao <jmgao at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ashi08104 at gmail dot com

--- Comment #12 from Josh Gao <jmgao at google dot com> ---
*** Bug 17296 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.