From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-16965-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 30827 invoked by alias); 6 Nov 2014 07:36:48 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 30801 invoked by uid 48); 6 Nov 2014 07:36:47 -0000
From: "xdje42 at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/17559] confusion on what the result of find_pc_symtab is
Date: Thu, 06 Nov 2014 07:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: xdje42 at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-17559-4717-931txRTJtV@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-17559-4717@http.sourceware.org/bugzilla/>
References: <bug-17559-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-q4/txt/msg00208.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=17559

--- Comment #4 from Doug Evans <xdje42 at gmail dot com> ---
This patch fixes my simple testcase.

diff --git a/gdb/disasm.c b/gdb/disasm.c
index 6ff3793..c3f99f1 100644
--- a/gdb/disasm.c
+++ b/gdb/disasm.c
@@ -410,13 +410,14 @@ gdb_disassembly (struct gdbarch *gdbarch, struct ui_out
*uiout,
   struct ui_file *stb = mem_fileopen ();
   struct cleanup *cleanups = make_cleanup_ui_file_delete (stb);
   struct disassemble_info di = gdb_disassemble_info (gdbarch, stb);
-  /* To collect the instruction outputted from opcodes.  */
+  struct symtab_and_line sal;
   struct symtab *symtab = NULL;
   struct linetable_entry *le = NULL;
   int nlines = -1;

   /* Assume symtab is valid for whole PC range.  */
-  symtab = find_pc_symtab (low);
+  sal = find_pc_line (low, 0);
+  symtab = sal.symtab;

   if (symtab != NULL && symtab->linetable != NULL)
     {

I think the thing to do, besides this (after some more testing), is rename
find_pc_symtab.
In my symtab reorg patch, find_pc_compunit works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.