From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21256 invoked by alias); 6 Nov 2014 18:57:49 -0000 Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-prs-owner@sourceware.org Received: (qmail 21233 invoked by uid 48); 6 Nov 2014 18:57:48 -0000 From: "xdje42 at gmail dot com" To: gdb-prs@sourceware.org Subject: [Bug symtab/17559] confusion on what the result of find_pc_symtab is Date: Thu, 06 Nov 2014 18:57:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: symtab X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: xdje42 at gmail dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-q4/txt/msg00217.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=17559 --- Comment #5 from Doug Evans --- Filing here so I don't forget. I believe this is another case where we want that actual source's symtab (be it primary or non-primary), and thus find_pc_line would be a better choice here. void tui_show_disassem (struct gdbarch *gdbarch, CORE_ADDR start_addr) { struct symtab *s = find_pc_symtab (start_addr); ... } This case is not entirely clear, as I don't see "s" being used for TUI_DISASM_WIN, but I think the intent is there. -- You are receiving this mail because: You are on the CC list for the bug.