From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-16961-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 21539 invoked by alias); 6 Nov 2014 07:12:50 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 21517 invoked by uid 48); 6 Nov 2014 07:12:49 -0000
From: "xdje42 at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/17559] confusion on what the result of find_pc_symtab is
Date: Thu, 06 Nov 2014 07:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: xdje42 at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-17559-4717-YYdFuFjnyc@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-17559-4717@http.sourceware.org/bugzilla/>
References: <bug-17559-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-q4/txt/msg00204.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=17559

--- Comment #1 from Doug Evans <xdje42 at gmail dot com> ---
Data point:
If (hypothetically) we fix find_pc_symtab to work the way gdb_disassembly
expects it to, I suspect we'll break this usage here in frame.c:

      /* We retrieve the frame's symtab by using the frame PC.                  
         However we cannot use the frame PC as-is, because it usually           
         points to the instruction following the "call", which is               
         sometimes the first instruction of another function.  So we            
         rely on get_frame_address_in_block() which provides us with a          
         PC which is guaranteed to be inside the frame's code                   
         block.  */
      if (get_frame_address_in_block_if_available (fi, &pc))
        {
          struct symtab *s = find_pc_symtab (pc); //xyzdje                      

          if (s
              && s->language != current_language->la_language
              && s->language != language_unknown
              && language_mode == language_mode_auto)
            set_language (s->language);
        }

For example, if we stop in a .h file included by a c++ file,
will this set the language to C (instead of the right answer of C++)?

An open question I have is: Is the language of non-primary symtabs (e.g.,
headers) ever useful (except as is currently used in the heuristics to try to
compute the language of the primary symtab) ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.