public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug gdb/17627] In MI all-stop/mi-async off mode, a thread exit make the prompt (kind of) return, but it shouldn't Date: Wed, 10 Dec 2014 18:05:00 -0000 [thread overview] Message-ID: <bug-17627-4717-7Ytrdk0Noo@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-17627-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=17627 --- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "gdb and binutils". The branch, master has been updated via 1abf3a143773819e195fceaa485060dcac9e6089 (commit) from f4943d8253e8c9c539fd72d23e94a65f84c92d1a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1abf3a143773819e195fceaa485060dcac9e6089 commit 1abf3a143773819e195fceaa485060dcac9e6089 Author: Simon Marchi <simon.marchi@ericsson.com> Date: Wed Dec 10 13:03:47 2014 -0500 Restore terminal state in mi_thread_exit (PR gdb/17627) When a thread exits, the terminal is left in mode "terminal_is_ours" while the target executes. This patch fixes that. We need to manually restore the terminal setting in this particular observer. In the case of the other MI observers that call target_terminal_ours, gdb will end up resuming the inferior later in the execution and call target_terminal_inferior. In the case of the thread exit event, we still need to call target_terminal_ours to be able to print something, but there is nothing that gdb will need to resume after that. We therefore need to call target_terminal_inferior ourselves. gdb/ChangeLog: PR gdb/17627 * target.c (cleanup_restore_target_terminal): New function. (make_cleanup_restore_target_terminal): New function. * target.h (make_cleanup_restore_target_terminal): New declaration. * mi/mi-interp.c (mi_thread_exit): Use the new cleanup. Signed-off-by: Simon Marchi <simon.marchi@ericsson.com> ----------------------------------------------------------------------- Summary of changes: gdb/ChangeLog | 8 ++++++++ gdb/mi/mi-interp.c | 4 ++++ gdb/target.c | 34 ++++++++++++++++++++++++++++++++++ gdb/target.h | 4 ++++ 4 files changed, 50 insertions(+), 0 deletions(-) -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2014-12-10 18:05 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-19 20:38 [Bug gdb/17627] New: " simon.marchi at ericsson dot com 2014-11-20 15:33 ` [Bug gdb/17627] " simon.marchi at ericsson dot com 2014-12-09 10:07 ` mihai.ciric at gmail dot com 2014-12-09 14:51 ` mihai.ciric at gmail dot com 2014-12-10 18:05 ` cvs-commit at gcc dot gnu.org [this message] 2014-12-10 18:07 ` simon.marchi at ericsson dot com 2014-12-17 14:41 ` marc.khouzam at ericsson dot com 2014-12-17 14:47 ` simon.marchi at ericsson dot com 2014-12-25 0:46 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-17627-4717-7Ytrdk0Noo@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).