[Bug symtab/17684] New: lookup of builtin types: correctness and performance issues

[Bug symtab/17684] New: lookup of builtin types: correctness and performance issues

[xdje42 at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17684

            Bug ID: 17684
           Summary: lookup of builtin types: correctness and performance
                    issues
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: xdje42 at gmail dot com

This bug is to address the correctness and performance issues of gdb's current
handling of the lookup of builtin types, as discussed in PR 16994.

correctness: Though rare, we should still properly handle it,
which is if we're in a file where the STATIC_BLOCK doesn't provide a definition
for "double" (basetypes live in STATIC_BLOCK) and the fallback that gdb uses
(search all static blocks of all objfiles) happens to find a find a definition
of "double" in a file that was compiled with -fshort-double.

performance: We search in all static blocks of all objfiles.
The definition of "void" is typically not specified in debug info and yet gdb
can look up "void" a lot.  Thus every time gdb goes to search "void" it will
look in all static blocks of all objfiles, find nothing, and only *then* does
c-exp.y:classify_name, for example, call
language_lookup_primitive_type_by_name.

Fixing this will require giving lookup_symbol (et.al.) the ability to return
builtin types as symbols.  Patch to follow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/17684] lookup of builtin types: correctness and performance issues

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17684

dje at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |dje at google dot com
         Resolution|---                         |FIXED

--- Comment #1 from dje at google dot com ---
Patch set is here:
https://sourceware.org/ml/gdb-patches/2014-12/msg00521.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/17684] lookup of builtin types: correctness and performance issues

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17684

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=16994

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug symtab/17684] lookup of builtin types: correctness and performance issues

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17684

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.