public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug ada/17854] Nothing sets pspace_data->sym_cache? Date: Mon, 02 Feb 2015 03:40:00 -0000 [thread overview] Message-ID: <bug-17854-4717-ly6j8Xc1OL@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-17854-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=17854 --- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The gdb-7.9-branch branch has been updated by Joel Brobecker <brobecke@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=19a5737950b966d0ff3e50c01bb43742a870bb9e commit 19a5737950b966d0ff3e50c01bb43742a870bb9e Author: Joel Brobecker <brobecker@adacore.com> Date: Mon Feb 2 07:20:58 2015 +0400 [Ada] pspace_data->sym_cache is always NULL The Ada symbol cache has been designed to have one instance of that of that cache per program space, and for each instance to be created on-demand. ada_get_symbol_cache is the function responsible for both lookup and creation on demand. Unfortunately, ada_get_symbol_cache forgot to store the reference to newly created caches, thus causing it to: - Leak old caches; - Allocate a new cache each time the cache is being searched or a new entry is to be inserted. This patch fixes the issue by avoiding the use of the local variable, which indirectly allowed the bug to happen. We manipulate the reference in the program-space data instead. gdb/ChangeLog: PR gdb/17854: * ada-lang.c (ada_get_symbol_cache): Set pspace_data->sym_cache when allocating a new one. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2015-02-02 3:40 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-18 4:45 [Bug ada/17854] New: " xdje42 at gmail dot com 2015-01-18 4:47 ` [Bug ada/17854] " xdje42 at gmail dot com 2015-01-18 4:54 ` xdje42 at gmail dot com 2015-01-18 5:04 ` xdje42 at gmail dot com 2015-01-18 7:25 ` xdje42 at gmail dot com 2015-02-02 3:32 ` cvs-commit at gcc dot gnu.org 2015-02-02 3:40 ` cvs-commit at gcc dot gnu.org [this message] 2015-02-02 17:36 ` brobecker at gnat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-17854-4717-ly6j8Xc1OL@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).