From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-17400-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 20183 invoked by alias); 2 Feb 2015 03:32:19 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 20086 invoked by uid 55); 2 Feb 2015 03:32:18 -0000
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug ada/17854] Nothing sets pspace_data->sym_cache?
Date: Mon, 02 Feb 2015 03:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: ada
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-17854-4717-z1aMwDEBnZ@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-17854-4717@http.sourceware.org/bugzilla/>
References: <bug-17854-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q1/txt/msg00165.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=17854

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Joel Brobecker <brobecke@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=66c168ae56fa2d67f821ccae774fd25c695fd9ce

commit 66c168ae56fa2d67f821ccae774fd25c695fd9ce
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Mon Feb 2 07:20:58 2015 +0400

    [Ada] pspace_data->sym_cache is always NULL

    The Ada symbol cache has been designed to have one instance of that
    of that cache per program space, and for each instance to be created
    on-demand. ada_get_symbol_cache is the function responsible for both
    lookup and creation on demand.

    Unfortunately, ada_get_symbol_cache forgot to store the reference
    to newly created caches, thus causing it to:
      - Leak old caches;
      - Allocate a new cache each time the cache is being searched or
        a new entry is to be inserted.

    This patch fixes the issue by avoiding the use of the local variable,
    which indirectly allowed the bug to happen. We manipulate the reference
    in the program-space data instead.

    gdb/ChangeLog:

            PR gdb/17854:
            * ada-lang.c (ada_get_symbol_cache): Set pspace_data->sym_cache
            when allocating a new one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.