From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-17337-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 25040 invoked by alias); 18 Jan 2015 04:45:21 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 24916 invoked by uid 48); 18 Jan 2015 04:45:02 -0000
From: "xdje42 at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug ada/17854] New: Nothing sets pspace_data->sym_cache?
Date: Sun, 18 Jan 2015 04:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: ada
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: xdje42 at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter
Message-ID: <bug-17854-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q1/txt/msg00102.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=17854

            Bug ID: 17854
           Summary: Nothing sets pspace_data->sym_cache?
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ada
          Assignee: unassigned at sourceware dot org
          Reporter: xdje42 at gmail dot com

I think there's a bug in cache invalidation, but my testcase isn't exposing it.
That got me digging into the implementation of ada-lang.c's symbol lookup
cache.

It looks like nothing sets pspace_data->sym_cache.

Presumably, it should be set here.

static struct ada_symbol_cache *
ada_get_symbol_cache (struct program_space *pspace)
{
  struct ada_pspace_data *pspace_data = get_ada_pspace_data (pspace);
  struct ada_symbol_cache *sym_cache = pspace_data->sym_cache;

  if (sym_cache == NULL)
    {
      sym_cache = XCNEW (struct ada_symbol_cache);
      ada_init_symbol_cache (sym_cache);
    }

  return sym_cache;
}

Could be missing something though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.