[Bug tdep/17945] New: aarch64 lacks "deal_with_atomic_sequence"

[Bug tdep/17945] New: aarch64 lacks "deal_with_atomic_sequence"

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

            Bug ID: 17945
           Summary: aarch64 lacks "deal_with_atomic_sequence"
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tdep
          Assignee: unassigned at sourceware dot org
          Reporter: michael.hudson at canonical dot com

Currently single stepping through code that does load exclusive/store exclusive
always has the store exclusive fail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

Michael Hudson-Doyle <michael.hudson at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hudson at canonical dot co
                   |                            |m

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |qiyao at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

--- Comment #1 from Yao Qi <qiyao at gcc dot gnu.org> ---
(In reply to Michael Hudson-Doyle from comment #0)
> Currently single stepping through code that does load exclusive/store
> exclusive always has the store exclusive fail.

Can you elaborate or do you have a reproducer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

--- Comment #2 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
My test case was a binary produced by the in-progress port of go to arm64 so
not the easiest thing to reproduce.  You can see the conversation that lead me
to file this bug here: http://irclogs.linaro.org/2015/02/08/%23linaro-tcwg.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

--- Comment #3 from Yao Qi <qiyao at gcc dot gnu.org> ---
(In reply to Michael Hudson-Doyle from comment #2)
> My test case was a binary produced by the in-progress port of go to arm64 so
> not the easiest thing to reproduce.  You can see the conversation that lead
> me to file this bug here:
> http://irclogs.linaro.org/2015/02/08/%23linaro-tcwg.html

aarch64 GDB port should have support single stepping through atomic sequences,
in gdb/aarch64-tdep.c:

/* Implement the "software_single_step" gdbarch method, needed to
   single step through atomic sequences on AArch64.  */

static int
aarch64_software_single_step (struct frame_info *frame)

there might be bugs, but a reproduer can help us to locate the bugs quickly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[michael.hudson at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

--- Comment #4 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
Oh, hm.  How long has that been there?  If it's actually supposed to be
working, I'll definitely try to reproduce!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

--- Comment #5 from Yao Qi <qiyao at gcc dot gnu.org> ---
(In reply to Michael Hudson-Doyle from comment #4)
> Oh, hm.  How long has that been there?  If it's actually supposed to be

It was added in April 2014,

commit 9404b58f46328b3b171b0d5eeb0691bd685bc4f5
Author: Kyle McMartin <kmcmarti@redhat.com>
Date:   Wed Apr 30 12:04:50 2014 -0400

    aarch64: detect atomic sequences like other ll/sc architectures

    gdb/Changelog:

            * aarch64-tdep.c (aarch64_software_single_step): New function.
            (aarch64_gdbarch_init): Handle single stepping of atomic sequences
            with aarch64_software_single_step.

    gdb/testsuite/ChangeLog:

            * gdb.arch/aarch64-atomic-inst.c: New file.
            * gdb.arch/aarch64-atomic-inst.exp: New file.


> working, I'll definitely try to reproduce!

That will be great!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug tdep/17945] aarch64 lacks "deal_with_atomic_sequence"

[qiyao at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17945

Yao Qi <qiyao at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #6 from Yao Qi <qiyao at gcc dot gnu.org> ---
I'll close it.  If you still see something wrong in handling atomic sequence on
aarch64-linux.  Please re-open it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.