[Bug python/18089] New: py-prettyprint.c:print_children doesn't verify the result of the children iterator is a tuple

[Bug python/18089] New: py-prettyprint.c:print_children doesn't verify the result of the children iterator is a tuple

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18089

            Bug ID: 18089
           Summary: py-prettyprint.c:print_children doesn't verify the
                    result of the children iterator is a tuple
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
          Assignee: unassigned at sourceware dot org
          Reporter: dje at google dot com

I was getting this error from a pretty-printer:

SystemError: new style getargs format but argument is not a tuple

and traced it to this:

      if (! PyArg_ParseTuple (item, "sO", &name, &py_v))
        {
=>        gdbpy_print_stack ();
          Py_DECREF (item);
          continue;
        }

We first need to make sure item is a tuple.

This is important to fix because the user gets no python backtrace,
and no clue of where to start looking.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/18089] py-prettyprint.c:print_children doesn't verify the result of the children iterator is a tuple

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18089

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Doug Evans <devans@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=69b4374a87e5029ac4831c7a4471815514df662f

commit 69b4374a87e5029ac4831c7a4471815514df662f
Author: Doug Evans <dje@google.com>
Date:   Tue Apr 28 21:53:54 2015 -0700

    PR python/18089

    gdb/ChangeLog:

        PR python/18089
        * python/py-prettyprint.c (print_children): Verify result of children
        iterator.  Provide better error message.
        * python/python-internal..h (gdbpy_print_python_errors_p): Declare.
        * python/python.c (gdbpy_print_python_errors_p): New function.

    gdb/testsuite/ChangeLog:

        * gdb.python/py-bad-printers.c: New file.
        * gdb.python/py-bad-printers.py: New file.
        * gdb.python/py-bad-printers.exp: New file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug python/18089] py-prettyprint.c:print_children doesn't verify the result of the children iterator is a tuple

[dje at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18089

dje at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from dje at google dot com ---
patch committed

-- 
You are receiving this mail because:
You are on the CC list for the bug.