From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-prs-return-18053-listarch-gdb-prs=sources.redhat.com@sourceware.org>
Received: (qmail 22342 invoked by alias); 8 May 2015 11:39:35 -0000
Mailing-List: contact gdb-prs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-prs.sourceware.org>
List-Subscribe: <mailto:gdb-prs-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-prs/>
List-Post: <mailto:gdb-prs@sourceware.org>
List-Help: <mailto:gdb-prs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: gdb-prs-owner@sourceware.org
Received: (qmail 22309 invoked by uid 55); 8 May 2015 11:39:35 -0000
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/18208] Fails in gdb.base/coredump-filter.exp in remote
 testing
Date: Fri, 08 May 2015 11:39:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-18208-4717-kc1r9wtQKb@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-18208-4717@http.sourceware.org/bugzilla/>
References: <bug-18208-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-q2/txt/msg00247.txt.bz2

https://sourceware.org/bugzilla/show_bug.cgi?id=18208

--- Comment #13 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Yao Qi <qiyao@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=422349a385c2ccfc1e66f5c65560e5bd5fc97953

commit 422349a385c2ccfc1e66f5c65560e5bd5fc97953
Author: Yao Qi <yao.qi@linaro.org>
Date:   Fri May 8 12:37:48 2015 +0100

    Fix PR 18208: update /proc/pid/coredump_filter by c code

    Hi,
    We see some fails in gdb.base/coredump-filter.exp when we do remote
    gdbserver testing, like what I did for arm/aarch64 linux testing or
    run it with board file remote-gdbserver-on-localhost

     $ make check RUNTESTFLAGS='--target_board=remote-gdbserver-on-localhost
coredump-filter.exp'

    we find that this line in the test doesn't work as expected,

     remote_exec target "sh -c \"echo $filter_flag >
/proc/$ipid/coredump_filter\""

    although such pattern has been used in gdb testsuite somewhere else,
    but the special thing here is that we redirect the output to
    /proc/$ipid/coredump_filter on the remote target.  DejaGNU will
    redirect the output from the remote target to local, and looks tcl
    gets confused by these two redirection.

    After trying pass different parameters to remote_exec and hacking
    remote_exec/rsh_exec/local_exec, I got no success, I decide
    to give up, and try to update /proc/$ipid/coredump_filter by the c
    code directly.

    This patch adds a c function set_coredump_filter to update
    coredump_filter, and GDB calls it.

    gdb/testsuite:

    2015-05-08  Yao Qi  <yao.qi@linaro.org>

        PR gdb/18208
        * gdb.base/coredump-filter.c (set_coredump_filter): New function.
        * gdb.base/coredump-filter.exp (do_save_core): Call inferior
        function set_coredump_filter, and remove remote_exec call.
        Remove argument ipid.  Callers update.
        (top level): Don't get inferior's PID.

-- 
You are receiving this mail because:
You are on the CC list for the bug.