public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug varobj/18282] Pretty Printers - unable to create variable object (string value from children())
Date: Thu, 07 Sep 2023 20:06:01 +0000	[thread overview]
Message-ID: <bug-18282-4717-LbVxs3rk1l@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18282-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=18282

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aa15623fe68b3151ed54a7365b5a5226b538851a

commit aa15623fe68b3151ed54a7365b5a5226b538851a
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Aug 31 13:01:00 2023 -0600

    Allow pretty-printer 'children' method to return strings

    A user noticed that, while a pretty-printer can return Python strings
    from its "children" method, this does not really work for MI.  I
    tracked this down to my_value_of_variable calling into
    c_value_of_variable, which specially handles arrays and structures --
    not using the actual contents of the string.

    Now, this part of MI seems bad to me, but rather than change that,
    this applies the fix to only dynamic varobjs, which is the only
    scenario where a string like this can really be returned.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18282
    Reviewed-by: Keith Seitz <keiths@redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-09-07 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 14:32 [Bug mi/18282] New: Pretty Printers - prints string value as char[] from children() david.docteur at intel dot com
2015-04-20 14:40 ` [Bug mi/18282] Pretty Printers - unable to create variable object (string value from children()) david.docteur at intel dot com
2015-04-20 15:37 ` xdje42 at gmail dot com
2015-04-21 13:03 ` david.docteur at intel dot com
2021-07-02 20:32 ` alex.zhigay at yandex dot ru
2023-08-31 16:13 ` tromey at sourceware dot org
2023-08-31 17:17 ` [Bug varobj/18282] " tromey at sourceware dot org
2023-08-31 17:54 ` tromey at sourceware dot org
2023-08-31 18:21 ` tromey at sourceware dot org
2023-09-07 20:06 ` cvs-commit at gcc dot gnu.org [this message]
2023-09-07 20:07 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-18282-4717-LbVxs3rk1l@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).