public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
* [Bug python/18304] New: xmethod implementations should not have to test their enabled flag
@ 2015-04-22 23:05 dje at google dot com
  2015-04-22 23:28 ` [Bug python/18304] " sivachandra at gmail dot com
  0 siblings, 1 reply; 2+ messages in thread
From: dje at google dot com @ 2015-04-22 23:05 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=18304

            Bug ID: 18304
           Summary: xmethod implementations should not have to test their
                    enabled flag
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: python
          Assignee: unassigned at sourceware dot org
          Reporter: dje at google dot com

I noticed in a couple of xmethod implementations the testing of the enabled
flag.

gdb should handle all of this.
Need to verify the current examples are unnecessary and remove them.

See: testsuite/gdb.python/py-xmethods.py, and xmethods.py in libstdc++.

[While xmethods *can* test the enabled flag if they *want* to, early
implementations serve as boilerplate and we don't want this code propagated.]

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread
* [Bug python/18304] xmethod implementations should not have to test their enabled flag
  2015-04-22 23:05 [Bug python/18304] New: xmethod implementations should not have to test their enabled flag dje at google dot com
@ 2015-04-22 23:28 ` sivachandra at gmail dot com
  0 siblings, 0 replies; 2+ messages in thread
From: sivachandra at gmail dot com @ 2015-04-22 23:28 UTC (permalink / raw)
  To: gdb-prs

https://sourceware.org/bugzilla/show_bug.cgi?id=18304

Siva Chandra <sivachandra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sivachandra at gmail dot com

--- Comment #1 from Siva Chandra <sivachandra at gmail dot com> ---
I think this is wrt workers and not matchers. IIRC, this is something that
comes in because we wanted to parallel the pretty printer behavior.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-22 23:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-22 23:05 [Bug python/18304] New: xmethod implementations should not have to test their enabled flag dje at google dot com
2015-04-22 23:28 ` [Bug python/18304] " sivachandra at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).