public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "dilyan.palauzov at aegee dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/18632] New: Don't build readline/libreadline.a, when --with-system-readline is supplied
Date: Tue, 07 Jul 2015 10:20:00 -0000	[thread overview]
Message-ID: <bug-18632-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=18632

            Bug ID: 18632
           Summary: Don't build readline/libreadline.a, when
                    --with-system-readline is supplied
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: dilyan.palauzov at aegee dot org
  Target Milestone: ---

The bundled libreadline is always built, even if the system is ./configure'd
--with-system-readline and the build libreadline.a is not used.

Proposed patch:

Fix ./configure.ac not to proceed readline/, when --with-system-readline is
provided

diff --git a/configure.ac b/configure.ac
index 159f968..adf6dfb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi

+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with X, 
 # it's not even worth trying to configure, much less build, that tool.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


             reply	other threads:[~2015-07-07 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 10:20 dilyan.palauzov at aegee dot org [this message]
2021-08-26  5:58 ` [Bug build/18632] " pinskia at gcc dot gnu.org
2022-10-20  9:14 ` vries at gcc dot gnu.org
2022-10-20 15:06 ` vries at gcc dot gnu.org
2022-10-21  7:00 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-18632-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).