From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 73CAA3858294; Wed,  6 Dec 2023 12:47:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73CAA3858294
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1701866864;
	bh=tqP5aMhuk2mol3jAUjr6pdruHzvegYe4WCBdXJWNnuM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=dJBQej6WOFLmy4KyCuhwDy85rurPX5DW567DizraghxQP4Wbpti2Fl/Y9h9WoBMtt
	 FwVACkMY5Y/mAbJ3Ow6ZE1gwUa+Sn7YWk3TYJ5IlTcgvNIdYd/5BPQFjVl4J2fFW4V
	 DhJus6xmZHQ3Y0i98ZQ60BVvpAQIHMl+/raFqBEA=
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug breakpoints/21969] watchpoint break not triggered on reverse
 continue
Date: Wed, 06 Dec 2023 12:47:43 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: breakpoints
X-Bugzilla-Version: 7.10
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-21969-4717-w3YIHzgbpw@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-21969-4717@http.sourceware.org/bugzilla/>
References: <bug-21969-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gdb-prs.sourceware.org>

https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hannes Domani <ssbssa@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D288363c1737f=
93e2f7cb8c06026c11a5ff77fb58

commit 288363c1737f93e2f7cb8c06026c11a5ff77fb58
Author: Hannes Domani <ssbssa@yahoo.de>
Date:   Wed Dec 6 13:45:51 2023 +0100

    Fix hardware watchpoints in replay mode

    Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597
    caused a regression that meant hardware watchpoint stops would not
    trigger in reverse execution or replay mode.  This was documented in
    PR breakpoints/21969.
    The problem is that record_check_stopped_by_breakpoint always overwrites
    record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT
    value which would be checked afterwards.

    This commit fixes that by not overwriting the stop-reason in
    record_full_stop_reason if we're not stopped at a breakpoint.

    And the test for hw watchpoints in gdb.reverse/watch-reverse.exp actual=
ly
    tested sw watchpoints again, since "set can-use-hw-watchpoints 1"
    doesn't convert enabled watchpoints to use hardware.
    This is fixed by disabling said watchpoint while enabling hw watchpoint=
s.
    The same is not done for gdb.reverse/watch-precsave.exp, since it's not
    possible to use hw watchpoints in restored recordings anyways.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969
    Approved-by: Guinevere Larsen <blarsen@redhat.com>

--=20
You are receiving this mail because:
You are on the CC list for the bug.=