From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B860A385DC1A; Tue,  7 Apr 2020 17:10:59 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B860A385DC1A
From: "ssbssa at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/22594] Possible access to unintended variable in
 "gdb/stabsread.c" line 1364
Date: Tue, 07 Apr 2020 17:10:59 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ssbssa at sourceware dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-22594-4717-0s875H3nC4@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-22594-4717@http.sourceware.org/bugzilla/>
References: <bug-22594-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2020 17:10:59 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D22594

Hannes Domani <ssbssa at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ssbssa at sourceware dot o=
rg

--- Comment #2 from Hannes Domani <ssbssa at sourceware dot org> ---
(In reply to Petru-Florin Mihancea from comment #0)
> While experimenting with a CodeSonar plugin we develop, we noticed a
> potential bug in file "gdb/stabsread.c" line 1364, function define_symbol=
=20
>=20
> 1359           *typedef_sym =3D *sym;
> 1360           SYMBOL_ACLASS_INDEX (typedef_sym) =3D LOC_TYPEDEF;
> 1361           SYMBOL_VALUE (typedef_sym) =3D valu;
> 1362           SYMBOL_DOMAIN (typedef_sym) =3D VAR_DOMAIN;
> 1363           if (TYPE_NAME (SYMBOL_TYPE (sym)) =3D=3D 0)
> 1364             TYPE_NAME (SYMBOL_TYPE (sym)) //HERE
> 1365               =3D obconcat (&objfile->objfile_obstack,
> 1366                           SYMBOL_LINKAGE_NAME (sym),
> 1367                           (char *) NULL);
> 1368           add_symbol_to_list (typedef_sym, &file_symbols);
>=20
> Shouldn't typedef_sym be used instead of sym (and maybe also in the previ=
ous
> line)? A similar issue might be in line 1320.
>=20
> Regards,
> Petru Florin Mihancea

Because of:
          *typedef_sym =3D *sym;

TYPE_NAME (SYMBOL_TYPE (sym)) and TYPE_NAME (SYMBOL_TYPE (typedef_sym)) are
equivalent, so it doesn't make a difference which one is used here.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=