* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
@ 2021-04-24 17:49 ` vapier at gentoo dot org
2021-04-26 14:37 ` nickc at redhat dot com
` (5 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: vapier at gentoo dot org @ 2021-04-24 17:49 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
Mike Frysinger <vapier at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|arm simu: |arm sim:
|Handle_Store_Double() |Handle_Store_Double()
|requires too strict |requires too strict
|alignment |alignment for v6+
Assignee|unassigned at sourceware dot org |nickc at redhat dot com
--- Comment #1 from Mike Frysinger <vapier at gentoo dot org> ---
looks like Handle_Load_Double does:
if (state->is_v6 && (addr & 0x3) == 0)
/* Word alignment is enough for v6. */
;
/* The address must be aligned on a 8 byte boundary. */
else if (addr & 0x7)
i guess we should copy that logic over to Handle_Store_Double ?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
2021-04-24 17:49 ` [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+ vapier at gentoo dot org
@ 2021-04-26 14:37 ` nickc at redhat dot com
2021-04-26 14:38 ` nickc at redhat dot com
` (4 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: nickc at redhat dot com @ 2021-04-26 14:37 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
--- Comment #2 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 13399
--> https://sourceware.org/bugzilla/attachment.cgi?id=13399&action=edit
Proposed patch
Agreed.
Aldy - does this patch solve the problem for you ?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
2021-04-24 17:49 ` [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+ vapier at gentoo dot org
2021-04-26 14:37 ` nickc at redhat dot com
@ 2021-04-26 14:38 ` nickc at redhat dot com
2021-04-26 15:42 ` aldyh at redhat dot com
` (3 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: nickc at redhat dot com @ 2021-04-26 14:38 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
Nick Clifton <nickc at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
` (2 preceding siblings ...)
2021-04-26 14:38 ` nickc at redhat dot com
@ 2021-04-26 15:42 ` aldyh at redhat dot com
2021-04-26 16:17 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 7+ messages in thread
From: aldyh at redhat dot com @ 2021-04-26 15:42 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
--- Comment #3 from aldyh at redhat dot com ---
On 4/26/21 4:37 PM, nickc at redhat dot com wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=22790
>
> --- Comment #2 from Nick Clifton <nickc at redhat dot com> ---
> Created attachment 13399
> --> https://sourceware.org/bugzilla/attachment.cgi?id=13399&action=edit
> Proposed patch
>
> Agreed.
>
> Aldy - does this patch solve the problem for you ?
I don't really have state on this. I ran into this while fixing an
unknown PR for GCC years ago, and wouldn't know how to reproduce even if
I tried though.
But it seems like the correct fix :).
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
` (3 preceding siblings ...)
2021-04-26 15:42 ` aldyh at redhat dot com
@ 2021-04-26 16:17 ` cvs-commit at gcc dot gnu.org
2021-04-26 16:18 ` nickc at redhat dot com
2021-04-26 21:37 ` vapier at gentoo dot org
6 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-26 16:17 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nick Clifton <nickc@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f6b9562fd912cc507ef4eb8be9ccb9f132810758
commit f6b9562fd912cc507ef4eb8be9ccb9f132810758
Author: Nick Clifton <nickc@redhat.com>
Date: Mon Apr 26 17:16:20 2021 +0100
Fix a bug in the ARM emulator which would not allow 4 byte alignment for
double word stores.
PR 22790
* armemu.c (Handle_Store_Double): Allow 4 byte alignment when
running in v6 mode.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
` (4 preceding siblings ...)
2021-04-26 16:17 ` cvs-commit at gcc dot gnu.org
@ 2021-04-26 16:18 ` nickc at redhat dot com
2021-04-26 21:37 ` vapier at gentoo dot org
6 siblings, 0 replies; 7+ messages in thread
From: nickc at redhat dot com @ 2021-04-26 16:18 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
Nick Clifton <nickc at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |NOTABUG
--- Comment #5 from Nick Clifton <nickc at redhat dot com> ---
Alright, patch applied.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug sim/22790] arm sim: Handle_Store_Double() requires too strict alignment for v6+
[not found] <bug-22790-4717@http.sourceware.org/bugzilla/>
` (5 preceding siblings ...)
2021-04-26 16:18 ` nickc at redhat dot com
@ 2021-04-26 21:37 ` vapier at gentoo dot org
6 siblings, 0 replies; 7+ messages in thread
From: vapier at gentoo dot org @ 2021-04-26 21:37 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=22790
Mike Frysinger <vapier at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|NOTABUG |FIXED
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 7+ messages in thread