From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 3CA123835832; Sat, 17 Apr 2021 19:56:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CA123835832
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/23743] GDB index file mmapping broken, ubsan => runtime
 error: load of misaligned address
Date: Sat, 17 Apr 2021 19:56:49 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: tromey at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-23743-4717-HaJ8VfzDDz@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-23743-4717@http.sourceware.org/bugzilla/>
References: <bug-23743-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Apr 2021 19:56:50 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D23743

--- Comment #20 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot g=
nu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D42c2c69462fd=
83db2e0532ee57c44091bc1032f9

commit 42c2c69462fd83db2e0532ee57c44091bc1032f9
Author: Tom Tromey <tom@tromey.com>
Date:   Sat Apr 17 13:56:36 2021 -0600

    Handle unaligned mapping of .gdb_index

    The .gdb_index was designed such that all data would be aligned.
    Unfortunately, we neglected to require this alignment in the objcopy
    instructions in the manual.  As a result, in many cases, a .gdb_index
    in the wild will not be properly aligned by mmap.  This yields
    undefined behavior, which is PR gdb/23743.

    This patch fixes the bug by always assuming that the mapping is
    unaligned, and using extract_unsigned_integer when needed.  A new
    helper class is introduced to make this less painful.

    gdb/ChangeLog
    2021-04-17  Tom Tromey  <tom@tromey.com>

            PR gdb/23743:
            * dwarf2/read.c (class offset_view): New.
            (struct symbol_table_slot): Remove.
            (struct mapped_index) <symbol_table, constant_pool>: Change typ=
e.
            <symbol_name_index, symbol_vec_index>: New methods.
            <symbol_name_slot_invalid, symbol_name_at, symbol_name_count>:
            Rewrite.
            (read_gdb_index_from_buffer): Update.
            (struct dw2_symtab_iterator) <vec>: Change type.
            (dw2_symtab_iter_init_common, dw2_symtab_iter_init)
            (dw2_symtab_iter_next, dw2_expand_marked_cus): Update.
            * dwarf2/index-write.c (class data_buf) <append_data>: Remove.
            <append_array, append_offset>: New methods.
            (write_hash_table, add_address_entry, write_gdbindex_1)
            (write_debug_names): Update.
            * dwarf2/index-common.h (byte_swap, MAYBE_SWAP): Remove.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=