From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id D87D43858C2F; Tue, 9 Jan 2024 17:27:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D87D43858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1704821266; bh=RO6JXGCLhuIRiHA2KPG7nD4Pushf465+OtupvIBp0bA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=tkogYVVM21G3hJDxlL7tpF00f4PET0OwFIRbLl5rCxrnvIDBUfBdsURyPm6Fecqpl lm2/Ud+GIMEgXf9EdtaheZKXcSpCqdRdJ6IZRHHTpYmkRm4cpu3gePmnHw4S1T9mud N/UwyQ4Bk4aLLCroWGMRZB5cURPeyFBhBJQf5tYw= From: "blarsen at redhat dot com" To: gdb-prs@sourceware.org Subject: [Bug record/24073] Breakpoint on the first insn of recorded history is not reported in replay Date: Tue, 09 Jan 2024 17:27:46 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: record X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: blarsen at redhat dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D24073 Guinevere Larsen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blarsen at redhat dot com --- Comment #4 from Guinevere Larsen --- Hi Andrey! Sorry about this going unnoticed for 5 years (My god this is too long a tim= e). Reverse debugging wasn't getting much love at that time, but I've recently = been appointed maintainer on this area, so I'd be able to review your patch. Are= you still able and interested in contributing to this? If you are, this patch needs a rebase, and needs to use ecs->ws.set_stopped instead of setting the signal and kind manually. It also needs a test in the style of the testsuite (written in TCL), there should be plenty of tests in= the gdb/testsuite/gdb.record subdirectory to help (and of course, feel free to reach out in the gdb mailing list). Most importantly, the commit message needs work. Commit logs should usually explain the issue, when applicable an example (in this case I don't really think it's necessary) and explain the solution in general terms. For instan= ce, I expected this patch to always report that the end of story as a breakpoint hit and got really surprise that it doesn't. I think the commit message sho= uld explain why. --=20 You are receiving this mail because: You are on the CC list for the bug.=