[Bug gdb/24480] gdb drops toplevel types with -fdebug-types-section

[Bug gdb/24480] gdb drops toplevel types with -fdebug-types-section

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24480

--- Comment #6 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Christian Biesinger from comment #5)
> Mark, could you send that patch to the gdb-patches@sourceware.org mailing
> list, as per https://sourceware.org/gdb/wiki/ContributionChecklist ?

https://sourceware.org/pipermail/gdb-patches/2020-January/164813.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/24480] gdb drops toplevel types with -fdebug-types-section

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24480

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=770479f223ecd1920dd3cc683b05b24af25c4613

commit 770479f223ecd1920dd3cc683b05b24af25c4613
Author: Mark Williams <mark@myosotissp.com>
Date:   Tue Apr 28 16:12:45 2020 +0200

    gdb: Fix toplevel types with -fdebug-types-section

    When debugging a program compiled with -fdebug-types-section,
    only the first top-level type in each file is visible to gdb.

    The problem was caused by moving the assignment to list_in_scope
    from process_full_comp_unit and process_full_type_unit to
    start_symtab.  This was fine for process_full_comp_unit, because
    symtabs and comp units are one-to-one.  But there can be many type
    units per symtab (one for each type), and we only call start_symtab
    for the first one.  This adds the necessary assignments on the paths
    where start_symtab is not called.

    gdb/Changelog:

    2020-04-28 Mark Williams <mark@myosotissp.com>

            PR gdb/24480
            * dwarf2read.c: Add missing assingments to list_in_scope when
            start_symtab was already called.

    gdb/testsuite/Changelog:

    2020-04-28 Mark Williams <mark@myosotissp.com>

            PR gdb/24480
            * dw4-toplevel-types.exp: Test for top level types.
            * dw4-toplevel-types.cc: Test for top level types.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/24480] gdb drops toplevel types with -fdebug-types-section

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24480

--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
*** Bug 25886 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/24480] gdb drops toplevel types with -fdebug-types-section

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24480

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |10.1

--- Comment #9 from Tom de Vries <vries at gcc dot gnu.org> ---
I've retested the minimal test-case from comment 3, and can confirm it passes
with the committed patch.

Patch with test-case committed, marking resolved-fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug gdb/24480] gdb drops toplevel types with -fdebug-types-section

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=24480

--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
FTR, the same problem was found, and a similar patch proposed here (
https://sourceware.org/pipermail/gdb/2020-March/000016.html ).

-- 
You are receiving this mail because:
You are on the CC list for the bug.