public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug rust/25025] FAIL: gdb.rust/generics.exp: print identity::<u32>(23u32)
Date: Fri, 24 Apr 2020 21:36:09 +0000	[thread overview]
Message-ID: <bug-25025-4717-3HOqADEJ3t@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25025-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25025

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=906bb4c58faa8e2c1c62e295f8054e75e910e5e8

commit 906bb4c58faa8e2c1c62e295f8054e75e910e5e8
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Apr 24 15:35:01 2020 -0600

    Fix Rust test cases

    PR rust/25025 notes that some Rust test cases fail.

    Debugging gdb revealed that the Rust compiler emits different linkage
    names that demangle to the same result.  Enabling complaints when
    reading the test case is enough to show it:

        During symbol reading: Computed physname <generics::identity<f64>> does
not match demangled <generics::identity> (from linkage
<_ZN8generics8identity17h8540b320af6656d6E>) - DIE at 0x424 [in module
/home/tromey/gdb/build/gdb/testsuite/outputs/gdb.rust/generics/generics]
        During symbol reading: Computed physname <generics::identity<u32>> does
not match demangled <generics::identity> (from linkage
<_ZN8generics8identity17hae302fad0c33bd7dE>) - DIE at 0x459 [in module
/home/tromey/gdb/build/gdb/testsuite/outputs/gdb.rust/generics/generics]
        ...

    This patch changes the DWARF reader to prefer the computed physname,
    rather than the output of the demangler, for Rust.  This fixes the
    bug.

    gdb/ChangeLog
    2020-04-24  Tom Tromey  <tom@tromey.com>

            PR rust/25025:
            * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-04-24 21:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-25025-4717@http.sourceware.org/bugzilla/>
2020-03-20 16:16 ` tromey at sourceware dot org
2020-03-20 17:29 ` tromey at sourceware dot org
2020-03-24 15:35 ` tromey at sourceware dot org
2020-04-24 13:10 ` vries at gcc dot gnu.org
2020-04-24 21:36 ` cvs-commit at gcc dot gnu.org [this message]
2020-04-24 21:36 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25025-4717-3HOqADEJ3t@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).