[Bug sim/25211] sim: m68hc11: fails to remap registers when writing INIT

["vapier at gentoo dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=25211

--- Comment #6 from Mike Frysinger <vapier at gentoo dot org> ---
hmm, i poked it more today, and now i wonder if this is a bug in dv-core. 
looking through the codebase, m68hc11 seems to have the only device models that
ever actually call hw_detach_address which might be why no one noticed before.

practically speaking, it does the samething as your proposed patch because the
dv-m68hc11 detach method calls sim_core_detach.  but i think the right fix is
to change dv-core so it has mirror attach/detach logic.

i'll probably send this out after GDB 13 branches.

--- a/sim/common/dv-core.c       
+++ b/sim/common/dv-core.c
@@ -72,6 +72,23 @@ dv_core_attach_address_callback (struct hw *me,
 }


+static void
+dv_core_detach_address_callback (struct hw *me,
+                int level,
+                int space,
+                address_word addr,
+                address_word nr_bytes,
+                struct hw *client)
+{
+  HW_TRACE ((me, "detach - level=%d, space=%d, addr=0x%lx, nr_bytes=%ld,
client=%s",
+        level, space, (unsigned long) addr, (unsigned long) nr_bytes, hw_path
(client)));
+  /* NOTE: At preset the space is assumed to be zero.  Perhaphs the
+     space should be mapped onto something for instance: space0 -
+     unified memory; space1 - IO memory; ... */
+  sim_core_detach (hw_system (me), NULL, /*cpu*/ level, space, addr);
+}                                       
+
+
 static unsigned
 dv_core_dma_read_buffer_callback (struct hw *me,
                  void *dest,    
@@ -109,6 +126,7 @@ static void   
 dv_core_finish (struct hw *me)  
 {                               
   set_hw_attach_address (me, dv_core_attach_address_callback);
+  set_hw_detach_address (me, dv_core_detach_address_callback);
   set_hw_dma_write_buffer (me, dv_core_dma_write_buffer_callback);
   set_hw_dma_read_buffer (me, dv_core_dma_read_buffer_callback);
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.