From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id DB5663987867; Wed, 24 Jun 2020 20:44:41 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB5663987867
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/25475] FAIL: gdb.server/solib-list.exp: non-stop 0/1:
 target remote (got interactive prompt)
Date: Wed, 24 Jun 2020 20:44:41 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-25475-4717-K5CHKgUuZf@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-25475-4717@http.sourceware.org/bugzilla/>
References: <bug-25475-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2020 20:44:42 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D25475

--- Comment #23 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot g=
nu.org> ---
The master branch has been updated by Philippe Waroquiers
<philippe@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Da8654e7d7849=
80cb4596f685964200fcc1164c78

commit a8654e7d784980cb4596f685964200fcc1164c78
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Date:   Sun Jun 21 21:26:25 2020 +0200

    Fixes PR 25475: ensure exec-file-mismatch "ask" always asks in case of
mismatch.

    As explained in https://sourceware.org/bugzilla/show_bug.cgi?id=3D25475,
    when the currently loaded file has no debug symbol,
    symbol_file_add_with_addrs does not ask a confirmation to the user
    before loading the new symbol file.  The behaviour is not consistent
    when symbol_file_add_with_addrs is called due to exec-file-mismatch "as=
k"
    setting.

    The PR discusses several solutions/approaches.
    The preferred approach (suggested by Joel) is to ensure that GDB always
asks
    a confirmation when it loads a new symbol file due to exec-file-mismatc=
h,
    using a new SYMFILE add-flag.

    I tested this manually.  If OK, we can remove the bypass introduced by =
Tom
    in 6b9374f1, in order to always answer to the 'load' question.

    gdb/ChangeLog
    2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

            * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
            * exec.c (validate_exec_file): If from_tty, set both
            SYMFILE_VERBOSE (=3D=3D from_tty) and SYMFILE_ALWAYS_CONFIRM.
            * symfile.c (symbol_file_add_with_addrs): if always_confirm
            and from_tty, unconditionally ask a confirmation.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=