public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tdep/25489] RISC-V: NaN boxing not done for assignments to FPRs
Date: Wed, 25 Mar 2020 11:35:21 +0000	[thread overview]
Message-ID: <bug-25489-4717-kLVLhau8qj@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25489-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25489

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Burgess <aburgess@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dd8953924b0966e363c27ee38a0663c08f742fa0

commit dd8953924b0966e363c27ee38a0663c08f742fa0
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Fri Mar 13 15:50:28 2020 +0000

    gdb/riscv: Apply NaN boxing when writing return values into registers

    When setting up function parameters we already perform NaN boxing, as
    required by the RISC-V ABI, however, we don't do this when writing
    values into registers as part of setting up a return value.

    This commit moves the NaN boxing code into a small helper function,
    and then makes use of this function when setting up function
    parameters, and also when setting up return values.

    This should resolve this failure:

      FAIL: gdb.base/return-nodebug.exp: float: full width of the returned
result

    gdb/ChangeLog:

            PR gdb/25489
            * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
            (riscv_regcache_cooked_write): New function.
            (riscv_push_dummy_call): Use new function.
            (riscv_return_value): Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-03-25 11:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-25489-4717@http.sourceware.org/bugzilla/>
2020-03-13 16:43 ` andrew.burgess at embecosm dot com
2020-03-14  1:34 ` wilson at gcc dot gnu.org
2020-03-14  9:29 ` andrew.burgess at embecosm dot com
2020-03-14 10:58 ` andrew.burgess at embecosm dot com
2020-03-14 19:50 ` wilson at gcc dot gnu.org
2020-03-25 11:35 ` cvs-commit at gcc dot gnu.org [this message]
2020-03-30 11:02 ` andrew.burgess at embecosm dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25489-4717-kLVLhau8qj@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).