From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id CE616387703A; Thu, 12 Mar 2020 20:55:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE616387703A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1584046508; bh=FVZc25J+sDXdWXcNUbeubcOAe66pLAlPlFJrQwnj3iI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=uyeqW45RK+kTXpihCLG3bHJPaqI4coqKTISkhnuF7orsayefvIlOS1ikC/ViDUuYJ oraZXytV1MfRBUxU5YKmplKALdToxtmHz9a3FOetImFdatMo0T43804FfgOTOB75i2 K9UfT84hjhmurMsMs0ChNu8wd9LmVd61fCNXu+kA= From: "tromey at sourceware dot org" To: gdb-prs@sourceware.org Subject: [Bug gdb/25663] dwarf2_name caching bug Date: Thu, 12 Mar 2020 20:55:08 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: tromey at sourceware dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 20:55:08 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D25663 --- Comment #6 from Tom Tromey --- Created attachment 12369 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D12369&action=3Ded= it patch This seems to work ok. It just would be better if it cached the stripped name, like partial_die_info::fixup does. Also, canonicalizing the demangled name on the linkage name attribute just seems bad. Like, what if we want to examine the actual linkage name for some reason? Anyway this seems like a mild improvement, WDYT? --=20 You are receiving this mail because: You are on the CC list for the bug.=