public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/25755] Means to not keep decls in symtab
Date: Thu, 02 Apr 2020 23:14:20 +0000	[thread overview]
Message-ID: <bug-25755-4717-iyIKUxPdBW@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25755-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25755

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
I tried out this patch and ran the testsuite:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index f94c66b4f1..3d13e00554 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -20267,6 +20267,8 @@ new_symbol (struct die_info *die, struct type *type,
struct dwarf2_cu *cu,
                       ? cu->get_builder ()->get_global_symbols ()
                       : cu->list_in_scope);

+                 suppress_add = 1;
+
                  SYMBOL_ACLASS_INDEX (sym) = LOC_UNRESOLVED;
                }
              else if (!die_is_declaration (die, cu))
...

These were the new fails:
...
FAIL: gdb.base/symbol-alias.exp: p g_var_s_alias
FAIL: gdb.dwarf2/dw2-bad-unresolved.exp: ptype var
FAIL: gdb.dwarf2/dw2-bad-unresolved.exp: print var
FAIL: gdb.dwarf2/dw2-cu-size.exp: ptype noloc
FAIL: gdb.dwarf2/dw2-linkage-name-trust.exp: p c.membername
FAIL: gdb.dwarf2/dw2-linkage-name-trust.exp: p c.membername ()
FAIL: gdb.dwarf2/dw2-noloc.exp: no-run: print file_extern_locno_resolvable
FAIL: gdb.dwarf2/dw2-noloc.exp: no-run: ptype file_extern_locno_resolvable
FAIL: gdb.dwarf2/dw2-noloc.exp: in-main: print file_extern_locno_resolvable
FAIL: gdb.dwarf2/dw2-noloc.exp: in-main: ptype file_extern_locno_resolvable
FAIL: gdb.dwarf2/dw2-noloc.exp: print main_extern_locno_resolvable
FAIL: gdb.dwarf2/dw2-noloc.exp: ptype main_extern_locno_resolvable
FAIL: gdb.dwarf2/dw2-unresolved.exp: print/d var
FAIL: gdb.dwarf2/opaque-type-lookup.exp: p variable_a
FAIL: gdb.dwarf2/opaque-type-lookup.exp: p variable_b
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2020-04-02 23:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01  8:13 [Bug symtab/25755] New: " vries at gcc dot gnu.org
2020-04-01 13:29 ` [Bug symtab/25755] " vries at gcc dot gnu.org
2020-04-02 12:01 ` vries at gcc dot gnu.org
2020-04-02 23:14 ` vries at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25755-4717-iyIKUxPdBW@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).