public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/25857] Partial symtab expansion state influences lookup results
Date: Wed, 19 Jul 2023 11:41:25 +0000	[thread overview]
Message-ID: <bug-25857-4717-RGu23CSpO2@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25857-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25857

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative patch, reverse search order:
....
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 0117a2a59d7..7ae4a4b6d51 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -2503,6 +2503,15 @@ lookup_symbol_in_objfile (struct objfile *objfile, enum
block_enum block_index,
                              ? "GLOBAL_BLOCK" : "STATIC_BLOCK",
                              name, domain_name (domain));

+  result = lookup_symbol_via_quick_fns (objfile, block_index,
+                                       name, domain);
+  symbol_lookup_debug_printf ("lookup_symbol_in_objfile (...) = %s%s",
+                             result.symbol != NULL
+                             ? host_address_to_string (result.symbol)
+                             : "NULL",
+                             result.symbol != NULL ? " (via quick fns)"
+                             : "");
+
   result = lookup_symbol_in_objfile_symtabs (objfile, block_index,
                                             name, domain);
   if (result.symbol != NULL)
@@ -2513,14 +2522,6 @@ lookup_symbol_in_objfile (struct objfile *objfile, enum
block_enum block_index,
       return result;
     }

-  result = lookup_symbol_via_quick_fns (objfile, block_index,
-                                       name, domain);
-  symbol_lookup_debug_printf ("lookup_symbol_in_objfile (...) = %s%s",
-                             result.symbol != NULL
-                             ? host_address_to_string (result.symbol)
-                             : "NULL",
-                             result.symbol != NULL ? " (via quick fns)"
-                             : "");
   return result;
 }

...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-07-19 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  6:34 [Bug symtab/25857] New: " vries at gcc dot gnu.org
2020-08-09 20:45 ` [Bug symtab/25857] " tromey at sourceware dot org
2023-07-19 11:41 ` vries at gcc dot gnu.org [this message]
2023-07-19 12:48 ` vries at gcc dot gnu.org
2023-08-08 18:50 ` vries at gcc dot gnu.org
2023-08-08 18:57 ` sam at gentoo dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25857-4717-RGu23CSpO2@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).