public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/25950] [debug-names] Handle no "Hash Lookup Table"
Date: Thu, 18 Jan 2024 20:37:36 +0000	[thread overview]
Message-ID: <bug-25950-4717-4LfPPZfCi3@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25950-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25950

--- Comment #2 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3a862152958a1d17742cef7fc43c4d51dd2dcbab

commit 3a862152958a1d17742cef7fc43c4d51dd2dcbab
Author: Tom Tromey <tom@tromey.com>
Date:   Mon Dec 4 07:58:48 2023 -0700

    Empty hash table fix in .debug_names reader

    The handling of an empty hash table in the .debug_names reader is
    slightly wrong.

    Currently the code assumes there is always an array of hashes.
    However, section 6.1.1.4.5 Hash Lookup Table says:

        The optional hash lookup table immediately follows the list of
        type signatures.

    and then:

        The hash lookup table is actually two separate arrays: an array of
        buckets, followed immediately by an array of hashes.

    My reading of this is that the hash table as a whole is optional, and
    so the hashes will not exist in this case.  (This also makes sense
    because the hashes are not useful without the buckets anyway.)

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=25950

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-01-18 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 12:40 [Bug symtab/25950] New: " vries at gcc dot gnu.org
2023-12-10 15:16 ` [Bug symtab/25950] " tromey at sourceware dot org
2024-01-18 20:37 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-18 20:38 ` cvs-commit at gcc dot gnu.org
2024-01-18 20:38 ` tromey at sourceware dot org
2024-01-18 20:40 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25950-4717-4LfPPZfCi3@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).